fix: add recurringP2PTransferId to P2PTransfer - #385
Conversation
|
@tylerGroesbeckMx Please fill out the "How Has This Been Tested?" and "Checklist" sections in the MR template. |
| private String recipientId; | ||
| private String recipientVerificationAnswer; | ||
| private String recipientVerificationQuestion; | ||
| private String recurringP2PTransferId; |
There was a problem hiding this comment.
We should confirm that is is getting serialized to recurring_p2p_transfer_id as expected. Can you pull a snapshot version with this change into a path connector, populate the value, and provide an example response?
There was a problem hiding this comment.
Sure thing
There was a problem hiding this comment.
This was a good call, cause it ended up looking like this:
{
"p2p_transfer": {
"recurring_p2_p_transfer_id": "6902253",
"user_id": "U-00u3la36x0bbNvPud1d7"
}
}
That second p needs to be lowercased or I can annotate it. Pushing a fix now.
There was a problem hiding this comment.
Can we annotate it with @SerializedName instead? We are pretty consistent with capitalizing P2P in class and variable names elsewhere, so this would be a good use of an annotation.
fe4c956 to
8ddfc8a
Compare
Summary of Changes
Mobile core added recurring_p2p_transfer_id field to P2P Transfers and it needs to be added to path-model
path-model: https://github.com/mxenabled/path-mdx-model/blob/master/mdx-models/src/main/java/com/mx/path/model/mdx/model/p2p_transfer/P2PTransfer.java
spec: https://developer.mx.com/drafts/mdx/p2p_transfer/index.html#changes-rev-1-2025-10-22
Fixes # https://mxcom.atlassian.net/browse/GCU-1431
Public API Additions/Changes
P2PTransfer now has an additional field:
recurringP2PTransferIdDownstream Consumer Impact
This is just adding a field to an existing model so it shouldn't have a large impact.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: