fix(ios): skip subframe intercepts, improve auth popup support - #31
Merged
farfromrefug merged 1 commit intoSep 11, 2026
Merged
Conversation
modos189
force-pushed
the
fix/ios-popup-auth
branch
from
September 4, 2026 14:58
8cecec5 to
7e0ebe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on top of #33 - the
decisionHandler(Cancel)fix that was part of this PR landed there, so two changes remain.Subframe navigations
decidePolicyForNavigationActionfires for every frame, so an iframe navigating to another origin was passed toshouldOverrideUrlLoading. Apps that returntruefor external urls cancelled that navigation, breaking cross-origin auth flows (OAuth, gapi) that load their endpoints in a hidden frame. Only main-frame navigations are reported now.Side effect:
loadStartedis no longer emitted for subframes. That matches Android, whereonPageStartedfires for the main frame only.Popup presentation
UIApplication.sharedApplication.keyWindowis deprecated since iOS 13 and returnsnilin multi-scene apps, so the walk downpresentedViewControllerstarted from the wrong root - or from nothing at all. Start it from the webview's own window instead.