Draft
fix(Mastercontainer): send notification when container image pulls fail during daily backup#8511
Conversation
…il during daily backup When automatic updates are enabled and image pulls fail (e.g. due to registry issues, disk space, or host-level problems), AIO now: - Detects pull failures via PullImage() returning false - Collects all failed container image names - Writes failure details to a data file - Exits PullContainerImages.php with code 1 - Logs a warning in the daily-backup.sh output - Sends a notification to Nextcloud admins via BackupNotification.php Previously, pull failures were silently swallowed when images already existed locally, causing instances to run outdated images without any user-visible indication. Closes: #8452 Assisted-by: GitHub Copilot:claude-sonnet-4
Copilot created this pull request from a session on behalf of
szaimen
July 31, 2026 08:47
View session
szaimen
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When automatic updates are enabled,
PullImage()silently swallows pull failures if the image already exists locally — it logs viaerror_log()but returns void, exits 0, and no notification is ever sent. Instances can run stale images indefinitely with no admin-visible signal.Changes:
DockerActionManager::PullImage()— return typevoid→bool(falseon skip/failure with local fallback, still throws if no local image exists)DockerController::PerformRecursiveImagePull()— accumulates failed container names by referenceDockerController::PullAllContainerImages()— returnsstring[]of failures instead ofvoidPullContainerImages.php— writes failures todata/image_pull_failures, exits 1daily-backup.sh— checks exit code, logs warning, addselifbranch to send notification even without daily backup enabledBackupNotification.php— reads the failures file, sends "Container image update failed!" notification with affected image names, cleans upDataConst.php— addsGetImagePullFailuresFile()path constantBackup still proceeds with existing (older) images; the failure is reported, not blocking.
3. to review, feature component)AI (if applicable)
Assisted-by: GitHub Copilot (claude-sonnet-4)