draft: implement full Assistant features also on client by Rello · Pull Request #10345 · nextcloud/desktop

Rello · 2026-07-10T08:46:08Z

cover all server Assistant feature
continue conversations on server/client
isolated assistant dialog for better modularisation of the client

Rello · 2026-07-10T08:46:30Z

@kra-mo @jancborchardt

kra-mo · 2026-08-14T12:52:22Z

The Assistant on the web will likely be redesigned next cycle, so I'd maybe hold off on iterating on the UI for now.

Rello · 2026-08-21T06:36:31Z

The Assistant on the web will likely be redesigned next cycle, so I'd maybe hold off on iterating on the UI for now.

Hello,
next cycle you mean 36?
the current one is pretty useless so I would like to get at least the current approach in.
For simplicity I would suggests that we hide all buttons on the top and only default it to the "chat". because this feature will then sync with the conversations on the server.
the current implementation is pure temporary and super alpha. the proper chat-only implementation would make it actually very usable already

Rello · 2026-08-21T06:37:32Z

@copilot resolve the merge conflicts in this pull request

Rello · 2026-08-21T06:40:28Z

Reload icon we can remove I would say. its there to reload the conversations from the server. it is reloaded during the window startup. its not very likely that there are new conversations for the same user when they are currently in this dialog. less distraction.
new chat needs to move next to the conversation dropdown

Copilot · 2026-08-21T06:42:27Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts with origin/master have been resolved in commit a4d01ff. The resolution keeps both the unified search UI (from this PR) and the assistant panel features, while adopting master's updated file paths (src/gui/activity/qml/ActivitiesWindow.qml, src/gui/search/unifiedsearchresultslistmodel.h).

kra-mo · 2026-08-21T10:53:22Z

Hello,
next cycle you mean 36?

Yes.

For simplicity I would suggests that we hide all buttons on the top and only default it to the "chat". because this feature will then sync with the conversations on the server.

That's fine by me.

Rello · 2026-08-22T21:51:39Z

@kra-mo

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97e91ad54d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-22T21:53:18Z

+                section.delegate: UnifiedSearchResultSectionItem {
+                    width: unifiedSearchResultsListView.width


Close the unified-search component hierarchy

The newly added section.delegate begins a UnifiedSearchResultSectionItem here but never closes that delegate, the containing ListView, or its ScrollView before the following Dialog; the file consequently has three unmatched opening braces. MainWindow.qml therefore cannot be parsed, preventing the tray window from being instantiated for every desktop-client launch.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-22T21:53:18Z

+AssistantController::AssistantController(AccountStatePtr accountState, QObject *parent)
+    : QObject(parent)
+    , _accountState(std::move(accountState))
+    , _account(_accountState->account())
+    , _client(new AssistantClient(_account, this))


Add automated coverage for the Assistant workflows

This change introduces the Assistant controller, networking workflows, response models, and QML behavior without changing or adding any automated tests. Add focused coverage for successful requests, malformed/error responses, polling boundaries, and conversation state transitions before treating the feature as complete.

AGENTS.md reference: AGENTS.md:L33-L36

Useful? React with 👍 / 👎.

Move Assistant operations into a dedicated controller and expose task and chat workflows in a separate window. Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Remove the legacy tray implementation, encapsulate Assistant resources and networking, reject stale asynchronous replies, and bound chat polling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c66f53a706

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-23T18:32:51Z

-            header: Item {}
-            footer: Item {}
-            onOpened: assistantResetConfirmationDialog.open()
+        UnifiedSearchInputContainer {


Import the unified-search QML module

UnifiedSearchInputContainer and the other restored UnifiedSearch* components are declared only in the com.nextcloud.desktopclient.search module in src/gui/search/CMakeLists.txt, while this document imports only com.nextcloud.desktopclient; the QML engine will therefore report an unknown type and fail to instantiate the tray window. Fresh evidence after the earlier brace fix is that the component hierarchy is now closed, but the required module import is still absent. The added resource test checks only file existence, so add the import and exercise component instantiation.

AGENTS.md reference: AGENTS.md:L33-L36

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-23T18:32:51Z

+        }
+
+        auto name = typeObject.value("name"_L1).toString();


Reject task shapes that cannot be submitted

When a server advertises a translation task with multiple required inputs, such as source text and source/target languages, isTranslate bypasses the single-text-shape check and exposes it as supported; however, OcsAssistantConnector::scheduleTask() always sends only input[input]. If chat is unavailable this type can also become the automatic default, making every submission fail server-side. Either construct the request from the advertised input shape or exclude task types whose required fields the UI cannot supply, with coverage for multi-input shapes.

AGENTS.md reference: AGENTS.md:L33-L36

Useful? React with 👍 / 👎.

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

github-actions · 2026-08-24T05:42:12Z

Artifact containing the AppImage: nextcloud-appimage-pr-10345.zip

Digest: sha256:90c2ee18ffb51c2776bed2fe30c7c5e87929a148ede2aba92843599e16a9119f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarqubecloud · 2026-08-24T06:00:06Z

Quality Gate failed

Failed conditions
19.4% Coverage on New Code (required ≥ 80%)
257 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

kra-mo

An improvement

Rello added the design Design, UI, UX, etc. label Jul 10, 2026

Rello added this to the 34.0.1 milestone Jul 10, 2026

Rello changed the title ~~feat: implement full Assistant features also on client~~ draft: implement full Assistant features also on client Jul 10, 2026

Rello modified the milestones: 34.0.1, 34.0.2 Jul 30, 2026

Rello modified the milestones: 34.0.2, 35.0.0 Aug 11, 2026

Copilot started work on behalf of Rello August 21, 2026 06:37 View session

Copilot finished work on behalf of Rello August 21, 2026 06:43

Rello moved this to NC35 in 💻 Desktop Clients team Aug 21, 2026

Rello added this to 💻 Desktop Clients team Aug 21, 2026

Rello marked this pull request as ready for review August 22, 2026 21:50

Rello requested review from camilasan, claucambra, i2h3, mgallien and nilsding as code owners August 22, 2026 21:50

chatgpt-codex-connector Bot reviewed Aug 22, 2026

View reviewed changes

feat(assistant): add desktop assistant interface

26cdfe0

Move Assistant operations into a dedicated controller and expose task and chat workflows in a separate window. Signed-off-by: Rello <Rello@users.noreply.github.com> Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

Rello force-pushed the feature/newAssistant branch from 97e91ad to 26cdfe0 Compare August 23, 2026 06:28

fix(assistant): isolate module and harden request lifecycle

c66f53a

Remove the legacy tray implementation, encapsulate Assistant resources and networking, reject stale asynchronous replies, and bound chat polling. Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

chatgpt-codex-connector Bot reviewed Aug 23, 2026

View reviewed changes

fix(test): implement test feedback

0279ae1

Signed-off-by: Rello <github@scherello.de> Assisted-by: Codex:GPT-5

kra-mo approved these changes Aug 24, 2026

View reviewed changes

		section.delegate: UnifiedSearchResultSectionItem {
		width: unifiedSearchResultsListView.width

Uh oh!

Conversation

Rello commented Jul 10, 2026

Uh oh!

Rello commented Jul 10, 2026

Uh oh!

kra-mo commented Aug 14, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Rello commented Aug 21, 2026

Uh oh!

Copilot AI commented Aug 21, 2026

Uh oh!

kra-mo commented Aug 21, 2026

Uh oh!

Rello commented Aug 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

sonarqubecloud Bot commented Aug 24, 2026

Quality Gate failed

Uh oh!

kra-mo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants