Skip to content

fix(MessageTranslation): Use task processing API - #19344

Open
marcelklehr wants to merge 1 commit into
mainfrom
fix/use-taskprocessing-for-translation
Open

marcelklehr wants to merge 1 commit into
mainfrom
fix/use-taskprocessing-for-translation

Conversation

@marcelklehr

Copy link
Copy Markdown
Member

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Screencast.From.2026-09-08.15-45-31.mp4

🚧 Tasks

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Sep 8, 2026
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
marcelklehr force-pushed the fix/use-taskprocessing-for-translation branch from f1b896e to 9548b3b Compare September 8, 2026 13:48
Comment thread lib/Capabilities.php
Comment on lines +419 to +423
// The deprecated capability is kept in sync with the task
// processing one for clients which don't support the OCS
// TaskProcessing API yet, as the deprecated OCS Translation API
// is only a fallback for providers that did not migrate yet.
$capabilities['config']['chat']['has-translation-providers'] = true;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand this.

  • If the old OCS Translation API is working, 'has-translation-providers' should be set.
  • If that is no longer going to work, the capability should not be there anymore

Independent from that we can improve the frontend to rely on has-translation-task-providers and use the new way and otherwise fall back to check has-translation-providers and use the old way

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, you're right. I was confused about that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is the API going to be removed and we should make it false, or is it staying and we should keep it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the API is not being removed.

@nickvergessen nickvergessen added enhancement feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client labels Sep 14, 2026
@nickvergessen nickvergessen added this to the ☃️ Next Major (36) milestone Sep 14, 2026
@marcelklehr

Copy link
Copy Markdown
Member Author

@Antreesy Are you taking this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to the task processing API

3 participants