fix(MessageTranslation): Use task processing API - #19344
Open
marcelklehr wants to merge 1 commit into
Open
marcelklehr wants to merge 1 commit into
marcelklehr wants to merge 1 commit into
Conversation
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/use-taskprocessing-for-translation
branch
from
September 8, 2026 13:48
f1b896e to
9548b3b
Compare
Comment on lines
+419
to
+423
| // The deprecated capability is kept in sync with the task | ||
| // processing one for clients which don't support the OCS | ||
| // TaskProcessing API yet, as the deprecated OCS Translation API | ||
| // is only a fallback for providers that did not migrate yet. | ||
| $capabilities['config']['chat']['has-translation-providers'] = true; |
Member
There was a problem hiding this comment.
I don't fully understand this.
- If the old OCS Translation API is working,
'has-translation-providers'should be set. - If that is no longer going to work, the capability should not be there anymore
Independent from that we can improve the frontend to rely on has-translation-task-providers and use the new way and otherwise fall back to check has-translation-providers and use the old way
Member
Author
There was a problem hiding this comment.
Indeed, you're right. I was confused about that.
Member
There was a problem hiding this comment.
So is the API going to be removed and we should make it false, or is it staying and we should keep it?
Member
Author
There was a problem hiding this comment.
No, the API is not being removed.
Member
Author
|
@Antreesy Are you taking this on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Screencast.From.2026-09-08.15-45-31.mp4
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required