Refactor: Extract table cell component for better reusability - #2763
Open
Koc wants to merge 1 commit into
Open
Conversation
Koc
marked this pull request as draft
June 23, 2026 21:29
Koc
force-pushed
the
feature/extract-table-cell-component
branch
from
July 13, 2026 22:27
45c19be to
e8c70cb
Compare
1 task
Koc
marked this pull request as ready for review
July 13, 2026 22:28
Koc
force-pushed
the
feature/extract-table-cell-component
branch
4 times, most recently
from
July 15, 2026 23:00
7fed406 to
f3ef5e5
Compare
enjeck
reviewed
Jul 20, 2026
Koc
force-pushed
the
feature/extract-table-cell-component
branch
from
July 22, 2026 21:41
f3ef5e5 to
f8b63ab
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/extract-table-cell-component
branch
from
July 23, 2026 20:36
f8b63ab to
2fd7837
Compare
AIlkiv
self-requested a review
August 15, 2026 19:57
AIlkiv
reviewed
Aug 15, 2026
| - SPDX-License-Identifier: AGPL-3.0-or-later | ||
| --> | ||
| <template> | ||
| <component :is="cellComponent" |
Contributor
There was a problem hiding this comment.
Would it be possible to avoid introducing an additional TableCell component here? This adds one extra Vue component instance for every cell, which could become noticeable for large tables.
We could instead move getTableCell() (or the component mapping) into a regular JS module and import it where needed. This would provide the same reusability without adding an extra component layer to every cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for #2271 as we should be able to render cells in cells 馃く
馃弫 Checklist
/backport to stableX.X馃 AI (if applicable)