fix: ignore client sent option UUID and generate new UUID on column update - #2899
Open
samin-z wants to merge 2 commits into
Open
fix: ignore client sent option UUID and generate new UUID on column update#2899samin-z wants to merge 2 commits into
samin-z wants to merge 2 commits into
Conversation
…pdate Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
samin-z
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
blizzz
reviewed
Aug 20, 2026
blizzz
left a comment
blizzz
left a comment
Member
There was a problem hiding this comment.
Brief look, left a comment. But a UUID should never be regenerated, it must remain stable once assigned upon creation.
| $this->setUuid($existingUuid); | ||
| return; | ||
| } | ||
| $this->setUuid(Uuid::v7()->toRfc4122()); |
Member
There was a problem hiding this comment.
Not sure having it here. It should be exclusively generated when creating an option first time.
Contributor
Author
There was a problem hiding this comment.
thanks for the review, i refactored it.
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2897
Behaviour:
Upon column update, any UUID sent in the request payload is ignored (to prevent client manipulation and to preserve the server managed identity). existing options keep their stored UUID and new options get a newly generated one.
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)