perf: reuse fused depth output buffer - #321
Open
Magnushst wants to merge 1 commit into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 19 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the temporary
Vec<Event>created for each accepted depth or snapshot event in the Python market-depth fusion path.Append-style core methods now write directly into the persistent output vector. The existing vector-returning methods remain available as compatible wrappers.
Changes
update_bid_depth_intoandupdate_ask_depth_into.add=falseby restoring the previous output length after updating depth state.Correctness
A 20,000-event deterministic differential test compares emitted events and complete depth state after every update.
The sequence covers bid and ask updates, snapshots, deletions, stale timestamps, crossings and narrow and wide price ranges.
A binding test covers accepted output, stale events,
add=falsestate updates and invalid sides.All 260 benchmark pairs on each tested platform produced identical output counts and sequence checksums.
Performance
Representative one-million-event results:
The platform results are independent and were not combined.
Median allocation calls fell from 980,071.5 to 31. Cumulative requested bytes fell by 65.15%.
All measured depth and snapshot workloads improved. The unchanged BBO and clear-event branches were not benchmarked.
Testing
Passed:
The installed-wheel fusion smoke test also passed.
Workspace-wide checks were attempted. Remaining failures occur in unchanged examples, documentation tests and tests requiring absent data files. Detailed logs and raw benchmark samples are available on request.
Compatibility
Related issue
Closes #320.
Reviewer guide
The complete production and test change is contained in:
hftbacktest/src/depth/fuse.rspy-hftbacktest/src/fuse.rsThe important invariants are the order of appended events, stale-timestamp handling and
add=falsestate behaviour.