Skip to content

lookup: remove q - #1123

Open
MikeMcC399 wants to merge 6 commits into
nodejs:mainfrom
MikeMcC399:remove/q
Open

lookup: remove q#1123
MikeMcC399 wants to merge 6 commits into
nodejs:mainfrom
MikeMcC399:remove/q

Conversation

@MikeMcC399

Copy link
Copy Markdown
Contributor

Situation

q is deprecated and unsupported. It cannot therefore fulfil the Hard Requirements:

The maintainers of the module remain responsive when there are problems

Item Status
npm package https://www.npmjs.com/package/q
npm status deprecated
last published 1.5.1 Oct 19, 2017
repo location https://github.com/kriskowal/q
repo status archived on Jan 22, 2025
lookup maintainer(s) kriskowal

npm Author message:

You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)

Node.js npm macos ubuntu windows
22.23.1 10.9.8 pass pass pass
24.19.0 11.17.0 pass pass pass
26.7.0 11.19.0 fail fail fail
26.7.0 12.0.2 - fail -

Change

Remove q from lib/lookup.json

Checklist
  • npm test passes
  • contribution guidelines followed
    here

cc: @kriskowal

@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (d4cf2e2) to head (6be7fd8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399
MikeMcC399 marked this pull request as ready for review August 10, 2026 13:57
@MikeMcC399

This comment was marked as outdated.

@ljharb

ljharb commented Aug 21, 2026

Copy link
Copy Markdown
Member

Have their been concrete problems the maintainers have been unresponsive to? Nothing short of that can violate the hard requirements imo.

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

q should be removed from citgm.

q is not compatible with Node.js 26. It cannot be built and fails testing. The repo is archived meaning that no new issues can be opened and no further development is planned.

Steps to reproduce

Ubuntu 24.04.4 LTS, Node.js 24.7.0

git clone https://github.com/kriskowal/q
cd q
npm install

Logs

$ npm install
npm warn deprecated graceful-fs@1.2.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
npm warn deprecated rimraf@2.2.8: Rimraf versions prior to v4 are no longer supported
npm warn deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm warn deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm warn deprecated mkdirp@0.3.0: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated mkdirp@0.3.5: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm warn deprecated glob@3.1.21: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated electron@0.2.1: The original electron project has been moved. Visit github.com/logicalparadox/electron for more details.
npm warn deprecated glob@3.2.1: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated glob@3.2.11: Old versions of glob are not supported, and contain widely publicized security vulnerabilities, which have been fixed in the current version. Please update. Support for old versions may be purchased (at exorbitant rates) by contacting i@izs.me
npm warn deprecated coffee-script@1.3.3: CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
npm warn deprecated jade@0.26.3: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm warn deprecated jasmine-node@1.11.0: jasmine-node 1.x & 2.x are deprecated, with known vulnerability in jasmine-growl-reporter pre-2.0.0
npm warn deprecated mocha@1.11.0: Mocha v1.x is no longer supported.
npm warn deprecated sinon@1.7.3: 16.1.1
npm warn deprecated buster-core@0.6.4: No longer maintained

> q@1.5.1 prepublish
> grunt

Loading "uglify.js" tasks...ERROR
>> Error: Cannot find module '_stream_transform'
>> Require stack:
>> - /home/mike/github/PACKAGES/q/node_modules/browserify-zlib/src/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/gzip-size/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/maxmin/index.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt-contrib-uglify/tasks/uglify.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt/lib/grunt/task.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt/lib/grunt.js
>> - /home/mike/github/PACKAGES/q/node_modules/grunt-cli/bin/grunt
Warning: Task "uglify" not found. Use --force to continue.

Aborted due to warnings.
npm error code 3
npm error path /home/mike/github/PACKAGES/q
npm error command failed
npm error command sh -c grunt

@MikeMcC399

Copy link
Copy Markdown
Contributor Author

Have their been concrete problems the maintainers have been unresponsive to? Nothing short of that can violate the hard requirements imo.

@kriskowal would be welcome to respond here, however since the package is deprecated and the repo is archived, that is a clear message that there will be no response to issues, including to the incompatibility with Node.js 26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants