Skip to content

fix: export MetadataEntry types from @doc-kit/core - #1040

Open
btea wants to merge 2 commits into
nodejs:mainfrom
btea:fix/metadata-types-export
Open

fix: export MetadataEntry types from @doc-kit/core#1040
btea wants to merge 2 commits into
nodejs:mainfrom
btea:fix/metadata-types-export

Conversation

@btea

@btea btea commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Description

Add explicit exports map entries for the metadata types subpaths (./metadata/types and ./generators/metadata/types) pointing to types.d.ts. Previously, these paths only resolved through the ./* wildcard, which fails under bundler module resolution since an extensionless specifier can't resolve to a .d.ts file. This caused JSDoc import('@doc-kit/core/generators/metadata/types') type annotations across the react/node packages to silently fail, leaving params typed as any.

image

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format:check & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner August 15, 2026 06:05
@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 15, 2026 3:09pm

Request Review

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (15b3f3e) to head (e5c70e0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
+ Coverage   89.37%   89.46%   +0.09%     
==========================================
  Files         203      203              
  Lines       18986    19039      +53     
  Branches     1769     1782      +13     
==========================================
+ Hits        16968    17033      +65     
+ Misses       2011     1999      -12     
  Partials        7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/core/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants