Skip to content

fix(margin): margin is controlled by ui-components, not us - #1042

Open
avivkeller wants to merge 1 commit into
mainfrom
avivkeller-patch-1
Open

fix(margin): margin is controlled by ui-components, not us#1042
avivkeller wants to merge 1 commit into
mainfrom
avivkeller-patch-1

Conversation

@avivkeller

Copy link
Copy Markdown
Member

When building doc-kit using a brand new version of ui-components, the margin may be off by a few pixels, this rectifies that

@avivkeller
avivkeller requested a review from a team as a code owner August 15, 2026 17:30
@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 15, 2026 5:31pm

Request Review

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
e7a2261 2026-08-15T17:31:12.182Z View logs ↗

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (49cb713) to head (e7a2261).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1042   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         203      203           
  Lines       19039    19039           
  Branches     1782     1782           
=======================================
  Hits        17033    17033           
  Misses       1999     1999           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 6.2% faster (1.44 s → 1.35 s)
  • Peak memory: 0.5% lower (354.21 MB → 352.35 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 29.7% slower (16.42 s → 21.29 s)
  • Peak memory: 10.5% lower (2.42 GB → 2.16 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 5.3% slower (9.03 s → 9.51 s)
  • Peak memory: 4.8% higher (1.76 GB → 1.84 GB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 5.7% slower (8.03 s → 8.49 s)
  • Peak memory: 5.6% lower (1.82 GB → 1.72 GB)

orama-db Generator

Output size: 1 file changed · net +2.00 B

File size details
File Main PR Change
orama-db.json 9.13 MB 9.13 MB +2.00 B (+0.0%)

Performance estimate (single CI run)

  • Generation time: 5.7% slower (8.79 s → 9.29 s)
  • Peak memory: 4.0% higher (1.74 GB → 1.81 GB)

web Generator

Output size: 3 files changed · net -155.00 B

File size details
File Main PR Change
assets/style-X45QCql_.css 137.01 KB +137.01 KB
assets/style-RQdHDA9v.css 137.00 KB -137.00 KB (-100.0%)
all.html 31.71 MB 31.71 MB -168.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 3.6% faster (87.20 s → 84.06 s)
  • Peak memory: 5.3% higher (4.73 GB → 4.98 GB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants