async_hooks: remove legacy AsyncLocalStorage implementation - #63641
Open
mcollina wants to merge 2 commits into
Open
async_hooks: remove legacy AsyncLocalStorage implementation#63641mcollina wants to merge 2 commits into
mcollina wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63641 +/- ##
==========================================
- Coverage 90.13% 90.13% -0.01%
==========================================
Files 751 750 -1
Lines 252592 252373 -219
Branches 47535 47486 -49
==========================================
- Hits 227684 227465 -219
+ Misses 16227 16207 -20
- Partials 8681 8701 +20
🚀 New features to boost your workflow:
|
addaleax
added
semver-major
Flarna
reviewed
Jun 2, 2026
| als.run('test-context-1', common.mustCall(() => { | ||
| finished(readable, common.mustCall(() => { | ||
| assert.strictEqual(AsyncContextFrame.enabled || enabledHooksExist(), true); | ||
| assert.strictEqual(!!AsyncContextFrame.current() || enabledHooksExist(), true); |
Member
There was a problem hiding this comment.
I think this line can be removed together with const { enabledHooksExist } = require('internal/async_hooks');.
Member
Author
There was a problem hiding this comment.
Done, removed together with the now-unused imports and the --expose-internals flag.
Remove the async_hooks-based AsyncLocalStorage fallback and the --no-async-context-frame flag, making AsyncContextFrame the sole implementation.
Remove the AsyncContextFrame.enabled checks and the async_local_storage_context_symbol that only served the async_hooks based implementation, and stop spawning test-timers-async-store-leak with --no-async-context-frame.
mcollina
force-pushed
the
remove-async-hooks-als
branch
from
August 23, 2026 06:48
7972ebb to
23b757b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the async_hooks-based
AsyncLocalStoragefallback and the--no-async-context-frameflag, makingAsyncContextFramethe sole implementation.