Skip to content

src: treat signal-terminated tasks as failures - #64951

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner8
Open

src: treat signal-terminated tasks as failures#64951
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner8

Conversation

@Archkon

@Archkon Archkon commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Check term_signal when handling task runner process exits so scripts terminated by a signal do not incorrectly report success.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 2, 2026
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (bb76938) to head (7c56ad3).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64951      +/-   ##
==========================================
+ Coverage   90.28%   90.29%   +0.01%     
==========================================
  Files         760      760              
  Lines      247137   247137              
  Branches    46617    46618       +1     
==========================================
+ Hits       223122   223152      +30     
+ Misses      15493    15459      -34     
- Partials     8522     8526       +4     
Files with missing lines Coverage Δ
src/node_task_runner.cc 89.32% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Check term_signal when handling task runner process exits so scripts
terminated by a signal do not incorrectly report success.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants