src: return failure when task spawning fails - #64956
Open
Archkon wants to merge 1 commit into
Open
Conversation
Set a non-zero exit code and return immediately when uv_spawn() fails, since no process exit callback will be invoked. Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64956 +/- ##
==========================================
+ Coverage 90.27% 90.29% +0.01%
==========================================
Files 760 760
Lines 247137 247138 +1
Branches 46612 46621 +9
==========================================
+ Hits 223111 223152 +41
+ Misses 15497 15454 -43
- Partials 8529 8532 +3
🚀 New features to boost your workflow:
|
Member
|
What was the old behavior? Silently return? If so, is this kind of a breaking change? |
Contributor
Author
|
@avivkeller Not really, the old behavior just print error but wrongly mark exit_code as success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set a non-zero exit code and return immediately when uv_spawn() fails, since no process exit callback will be invoked.