Skip to content

src: return failure when task spawning fails - #64956

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner9
Open

src: return failure when task spawning fails#64956
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:taskrunner9

Conversation

@Archkon

@Archkon Archkon commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Set a non-zero exit code and return immediately when uv_spawn() fails, since no process exit callback will be invoked.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 2, 2026
Set a non-zero exit code and return immediately when uv_spawn()
fails, since no process exit callback will be invoked.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (93b1088) to head (553a48b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/node_task_runner.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64956      +/-   ##
==========================================
+ Coverage   90.27%   90.29%   +0.01%     
==========================================
  Files         760      760              
  Lines      247137   247138       +1     
  Branches    46612    46621       +9     
==========================================
+ Hits       223111   223152      +41     
+ Misses      15497    15454      -43     
- Partials     8529     8532       +3     
Files with missing lines Coverage Δ
src/node_task_runner.cc 88.82% <0.00%> (-0.50%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

Copy link
Copy Markdown
Member

What was the old behavior? Silently return?

If so, is this kind of a breaking change?

@Archkon

Archkon commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@avivkeller Not really, the old behavior just print error but wrongly mark exit_code as success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants