Skip to content

test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml - #64960

Open
panva wants to merge 4 commits into
nodejs:mainfrom
panva:actions-fips
Open

test,tools: accomodate FIPS provider in tests and add FIPS to test-shared.yml#64960
panva wants to merge 4 commits into
nodejs:mainfrom
panva:actions-fips

Conversation

@panva

@panva panva commented Aug 2, 2026

Copy link
Copy Markdown
Member

This PR adds an OpenSSL 3.5 w/ an enabled FIPS provider to GHA and updates the test suite to accomodate that (+ 3.0 and 4.0 for which i'm not proposing to add a test-shared.yml target).

panva added 2 commits August 2, 2026 16:26
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Aug 2, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@panva
panva requested a review from aduh95 August 2, 2026 14:31
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 2, 2026
@panva panva added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Aug 2, 2026
Comment thread tools/dep_updaters/update-nixpkgs-pin.sh
@github-actions

This comment was marked as outdated.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions

This comment was marked as outdated.

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 451 -> 457 => +6 6 / 457 = 1.3%
aarch64-linux 452 -> 458 => +6 6 / 458 = 1.3%
x86_64-darwin 387 -> 392 => +5 5 / 392 = 1.2%
aarch64-darwin 392 -> 397 => +5 5 / 397 = 1.2%
Total 1682 -> 1704 => +22 22 / 1704 = 1.2%
Changelog
@@ -1156,0 +1157,22 @@
+/nix/store/n0fwww26113p6hmldnn7md7dmgczhjkq-openssl-fips-3.5.7 (aarch64-darwin)
+/nix/store/qfkhzdv046wbjlyqzw6l90m3irs5vy1g-openssl-fips-3.5.7 (aarch64-linux)
+/nix/store/q88gmqwjs6c8ik331p3kkdixba9azw1b-openssl-fips-3.5.7 (x86_64-darwin)
+/nix/store/h441jdz3fwnrwmbr1q3brxz3vhq677w1-openssl-fips-3.5.7 (x86_64-linux)
+/nix/store/v9pxxwy1f4342kqz6x6n5v2q8n5lgj26-openssl-fips-3.5.7-bin (aarch64-darwin)
+/nix/store/93q82jdbbjiba1hciq5id10wdlxjygy6-openssl-fips-3.5.7-bin (aarch64-linux)
+/nix/store/bf6mmb1nkk0i0q1adawhbq612sphzsf5-openssl-fips-3.5.7-bin (x86_64-darwin)
+/nix/store/i3k15a6sl4z9h8f9r5wv75kfhp2v97z6-openssl-fips-3.5.7-bin (x86_64-linux)
+/nix/store/6xdib4mwsp0qhsj664bn4bh1a06p9zcd-openssl-fips-3.5.7-debug (aarch64-linux)
+/nix/store/ja95pr9jh329h3af736xldxpvgg1c6wh-openssl-fips-3.5.7-debug (x86_64-linux)
+/nix/store/ir2m5gh4xgglznrw3wrcsyzv2kwa0lkq-openssl-fips-3.5.7-dev (aarch64-darwin)
+/nix/store/m22skfjcai299wb68zaw004dz0pp2bnd-openssl-fips-3.5.7-dev (aarch64-linux)
+/nix/store/1wjqh5ky478ifmif51j2gpb8p8ghcsqx-openssl-fips-3.5.7-dev (x86_64-darwin)
+/nix/store/h46h9f57f19k2d4l53gs1scl6nm0xjsr-openssl-fips-3.5.7-dev (x86_64-linux)
+/nix/store/ma5x18w8z58w5mwkqfivrvmfv03c6gbb-openssl-fips-3.5.7-doc (aarch64-darwin)
+/nix/store/3c96w0ja5nvy37nkgysvd2sam3dpj8a1-openssl-fips-3.5.7-doc (aarch64-linux)
+/nix/store/nw4daacb9wds03x69kdyjdz2x0ibgd04-openssl-fips-3.5.7-doc (x86_64-darwin)
+/nix/store/d2pgpwk0vaabh848i125rbhl5alyfm9h-openssl-fips-3.5.7-doc (x86_64-linux)
+/nix/store/l2qhxc0gb43i90bayyi897777k1gx1da-openssl-fips-3.5.7-man (aarch64-darwin)
+/nix/store/yyhcqjnhi5azb7d1v4vm4c4jsscq9cip-openssl-fips-3.5.7-man (aarch64-linux)
+/nix/store/6zny6rw5q401jvs2pslr7kv5z82n61c8-openssl-fips-3.5.7-man (x86_64-darwin)
+/nix/store/6qgw4kfvy5axr2gkvz35c9qq44qy2c8a-openssl-fips-3.5.7-man (x86_64-linux)

@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (a6e7e6a) to head (6010ef4).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64960      +/-   ##
==========================================
- Coverage   90.30%   90.28%   -0.02%     
==========================================
  Files         760      760              
  Lines      247154   247239      +85     
  Branches    46613    46627      +14     
==========================================
+ Hits       223181   223217      +36     
- Misses      15443    15511      +68     
+ Partials     8530     8511      -19     
Files with missing lines Coverage Δ
lib/internal/crypto/webcrypto.js 97.81% <100.00%> (+<0.01%) ⬆️

... and 51 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants