Skip to content

test: allow half-open CONNECT tunnel sockets - #64973

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-https-proxy-request-invalid-char-in-url
Open

test: allow half-open CONNECT tunnel sockets#64973
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-https-proxy-request-invalid-char-in-url

Conversation

@trivikr

@trivikr trivikr commented Aug 3, 2026

Copy link
Copy Markdown
Member

Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22

CONNECT tunnels are full-duplex. When the upstream socket receives a FIN while the client-to-upstream pipe is still draining, the default socket behavior can produce EPIPE or ECONNRESET errors.

Keep the upstream socket half-open so both directions can drain. Separate request logs from transport errors to verify that teardown completes without errors.


Assisted-by: codex:gpt-5.6-sol

CONNECT tunnels are full-duplex. When the upstream socket receives a
FIN while the client-to-upstream pipe is still draining, the default
socket behavior can produce EPIPE or ECONNRESET errors.

Keep the upstream socket half-open so both directions can drain.
Separate request logs from transport errors to verify that teardown
completes without errors.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 3, 2026
@trivikr

trivikr commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (f43086d) to head (a83ef4f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64973      +/-   ##
==========================================
- Coverage   90.27%   90.27%   -0.01%     
==========================================
  Files         762      762              
  Lines      247515   247520       +5     
  Branches    46683    46680       -3     
==========================================
- Hits       223447   223445       -2     
- Misses      15485    15500      +15     
+ Partials     8583     8575       -8     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants