perf_hooks: add binary export/import to Histogram - #65434
Conversation
|
Review requested:
|
00936d8 to
fbcb489
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65434 +/- ##
========================================
Coverage 90.13% 90.14%
========================================
Files 751 751
Lines 253439 253789 +350
Branches 47730 47808 +78
========================================
+ Hits 228448 228775 +327
+ Misses 16256 16239 -17
- Partials 8735 8775 +40
🚀 New features to boost your workflow:
|
fbcb489 to
5d9f7ce
Compare
5d9f7ce to
dfaacaf
Compare
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Notes for the notable change: This PR gives Histogram a new binary interchange format |
dfaacaf to
28eb138
Compare
require('node:perf_hooks').importHistogram(new Uint8Array([
0xa3, // map(3)
0x01, 0x1b, 0,0,0x20,0,0,0,0,0, // 1 (lowest) = 2**45
0x02, 0x1b, 0,0,0x40,0,0,0,0,0, // 2 (highest) = 2**46
0x03, 0x05, // 3 (figures) = 5
]));This still bypasses the checks and triggers assert on |
|
Ugh. yeah, will have to make the validation more thorough.. will update shortly |
28eb138 to
9b57e4f
Compare
af64f27 to
cc71fac
Compare
Provide a binary export/import mechanism for histograms. Since there is no standard interchange format for histograms, using CBOR is meant to make the format as platform/runtime agnostic as possible while producing a compact/efficient result. No new dependency is introduced, we just encode the CBOR directly. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus
Signed-off-by: James M Snell <jasnell@gmail.com>
cc71fac to
b784466
Compare
Stacks on: #65416
Pay attention only to the last two commits.