net: surface errors from setKeepAlive handle calls - #65539
Open
waterWang wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
jasnell
approved these changes
Aug 25, 2026
jasnell
left a comment
Member
There was a problem hiding this comment.
Technically I'm afraid this might be semver-major. I'm happy to consider it just a bug fix if others agree. @nodejs/tsc?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65539 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.02%
==========================================
Files 751 751
Lines 253635 253638 +3
Branches 47786 47784 -2
==========================================
- Hits 228615 228580 -35
- Misses 16268 16310 +42
+ Partials 8752 8748 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #65529
`Socket.prototype.setKeepAlive()` ignored the error code returned by the
underlying handle, so a failed operation (e.g. a negative delay rejected by
the platform with `EINVAL`) reported success and returned the socket. The
adjacent `setTypeOfService()` already throws `ErrnoException` in this case.
This change makes `setKeepAlive()` consistent with `setTypeOfService()`:
when the handle returns a non-zero error and the platform is not Windows
(where keep-alive settings are best-effort), throw the `ErrnoException`.
A regression test stubs the handle to return `UV_EINVAL` and asserts the
error is surfaced with the right `code`/
syscall.