module: forward execArgv to ESM loader hook worker - #65543
Open
santusht06 wants to merge 1 commit into
Open
Conversation
When spawning the internal worker thread for asynchronous loader hooks in AsyncLoaderHookWorker, process.execArgv was not passed to the InternalWorker constructor options. As a result, custom CLI flags such as `--conditions <tag>` set when creating a Worker thread were omitted from the loader hook worker thread's environment. This commit forwards `process.execArgv` to the `InternalWorker` instance so that loader hooks registered within worker threads receive custom conditions and options. Fixes: nodejs#50885 Signed-off-by: Santusht kotai <115890693+santusht06@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When spawning the internal worker thread for asynchronous loader hooks in
AsyncLoaderHookWorker(lib/internal/modules/esm/hooks.js),process.execArgvwas not passed to theInternalWorkerconstructor options.As a result, custom CLI flags such as
--conditions <tag>set when creating aWorkerthread were omitted from the loader hook worker thread's options.Changes
execArgv: process.execArgvtonew InternalWorker('internal/modules/esm/worker', ...)inlib/internal/modules/esm/hooks.js.test/es-module/test-esm-loader-worker-conditions.mjsto verify that custom conditions passed to aWorkerare properly forwarded and accessible to the ESM loader hook thread.Fixes: #50885