object server: resolve log error TODOs for remote node operations - #4142
Conversation
Co-authored-by: roman-khimov <22092804+roman-khimov@users.noreply.github.com>
roman-khimov
left a comment
There was a problem hiding this comment.
I think all of these are Debug level. Failure to perform some action on remote node is normal in general for many reasons and we can't spam logs in this case.
Open to other suggestions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
+ Coverage 29.78% 30.10% +0.31%
==========================================
Files 678 679 +1
Lines 40860 40897 +37
==========================================
+ Hits 12171 12310 +139
+ Misses 28689 28587 -102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I tend to agree: Debug seems more appropriate here to avoid excessive warning logs from expected remote-node failures. |
|
@copilot, make these messages debug level as per review comments |
Co-authored-by: roman-khimov <22092804+roman-khimov@users.noreply.github.com>
Done — all four log sites changed from |
The object server gained internal logic in #3097 but had no logging, leaving four
// TODO: log errorstubs in remote-forwarding paths where failures were silently swallowed or only surfaced as returned errors.Changes
putStream: Addedlog *zap.Loggerfield; plumbed fromServervianewIntermediatePutStream.sendToRemoteNodenow warns on per-connection failure insideForAnyGRPCConn.convertHeadPrm: Addedlog *zap.Loggerparameter; transport func warns whengetHeaderFromRemoteNodefails on a connection attempt.convertGetPrm: Addedlog *zap.Loggerparameter; transport func warns whencontinueWithConnfails on a connection attempt.searchOnRemoteNode: Uses existings.logto warn whensearchOnRemoteAddressfails on a connection attempt.All four sites log at
Warnlevel —ForAnyGRPCConnmay retry on another endpoint, so these are per-connection failures, not necessarily fatal outcomes.