Windows Installer: optional removal of user data on uninstall - #342
Draft
hendrikmennen with Copilot wants to merge 2 commits into
Draft
Windows Installer: optional removal of user data on uninstall#342hendrikmennen with Copilot wants to merge 2 commits into
hendrikmennen with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: hendrikmennen <25281882+hendrikmennen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add option to remove AppData and OneWareStudio folders
Windows Installer: optional removal of user data on uninstall
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uninstalling OneWare Studio always left
%APPDATA%\OneWareStudioand%USERPROFILE%\OneWareStudiobehind. This adds an opt-in step to delete both, without ever touching them during updates.UI (
RemoveUserDataDlg.wxs,UI.wxs,Common.wxl)REMOVEUSERDATA, unchecked by default.MaintenanceTypeDlg→ Remove → new dialog →VerifyReadyDlg(via a higher-OrderPublishoverriding the default navigation).Preselected): sequenced inInstallUISequencebeforeProgressDlg, conditioned onInstalled AND Preselected AND REMOVE~="ALL" AND NOT PATCH AND NOT UPGRADINGPRODUCTCODE.Removal (
StudioComponents.wxs)UserDataCleanupComponent(HKLM registry keypath) usingutil:RemoveFolderExfrom the already-referenced Util extension. The folder properties use environment variables, which the custom action expands in the user context:Update safety
RemoveExistingProductswith no UI andUPGRADINGPRODUCTCODEset, so the property is never set and the condition additionally excludes that case.REMOVEUSERDATA=1is passed explicitly.Paths mirror
OneWare.Core/Services/Paths.cs(AppDataDirectory,DocumentsDirectory); custom locations set viaONEWARE_DIR/ONEWARE_APPDATA_DIRare intentionally not touched.Note: WiX authoring only compiles/links on Linux — the generated MSI itself has not been exercised on Windows, so the dialog flow is worth a manual check.