[CONFIGURATION/TEST] SdkBuilder test separation and expansion by provider type - #4441
Open
dbarker wants to merge 10 commits into
Open
[CONFIGURATION/TEST] SdkBuilder test separation and expansion by provider type#4441dbarker wants to merge 10 commits into
dbarker wants to merge 10 commits into
Conversation
… and improve propogator coverage
…s and expand test coverage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4441 +/- ##
==========================================
+ Coverage 82.61% 85.59% +2.98%
==========================================
Files 511 511
Lines 20132 20132
==========================================
+ Hits 16631 17229 +598
+ Misses 3501 2903 -598 🚀 New features to boost your workflow:
|
dbarker
marked this pull request as ready for review
August 17, 2026 03:22
…ng aggregation for view config tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #4352 (Step three from #4352 (comment))
In order to verify
configuration_coreis independent of SDK signal libraries and to validate the SdkBuilder breakup into signal specific builders/utils, this PR focuses on separating tests in thesdk/test/configurationby provider type (trace, metrics, logs, propagation).Only
sdk/test/configurationtest files are changed in this PR.Additionally the tests are expanded to verify each signal provider and its SDK components can be built using all registry builders for the signal through the
SdkBuilder's methods. This is important to support the next step to split out the SDK component creation functions from theSdkBuilderinto signal specific files and break its dependency on signal libraries.Changes
config_test_common.htest file into separate files per signal (3dedf6a) and remove it.logs_builders_test.cc,metrics_builders_test.cc,trace_builders_test.cc:{Metrics,Logs,Trace}BuildersTestfixture registers all signal specific builders on SetUp and provides functions to use SdkBuilder (to be replaced with signal specific utility functions in the next PR).SdkBuilder::{Create,Add,Set}*to create SDK objects from config models and verify them{Meter,Logger,Tracer}Providers with models that cover the available exporters and processors.metrics_builder_test.ccCreateAttributesProcesscase.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes