[SDK] Add missing cstdint include to predicate_factory.h - #4574
Merged
dbarker merged 5 commits intoSep 16, 2026
Merged
Conversation
predicate_factory.h uses uint8_t but does not include cstdint, relying on a transitive include pulled in elsewhere in the translation unit. Building this header on its own fails with newer standard library implementations that no longer provide that transitive include.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4574 +/- ##
==========================================
- Coverage 86.52% 86.51% -0.00%
==========================================
Files 525 525
Lines 20464 20464
==========================================
- Hits 17704 17702 -2
- Misses 2760 2762 +2
🚀 New features to boost your workflow:
|
ThomsonTan
approved these changes
Sep 15, 2026
lalitb
approved these changes
Sep 16, 2026
lalitb
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the fix. Also good to open a follow-up issue to extend our IWYU checks to headers without a matching .cc file. We can handle that separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Changes
predicate_factory.hdeclaresenum class PredicateType : uint8_tand usesuint8_twithout including<cstdint>. It compiles today only because something else in the same translation unit happens to pull that header in transitively. Building it in isolation, or under a standard library that no longer provides that transitive include, fails to compile. This adds the missing#include <cstdint>directly to the header that needs it.CHANGELOG.mdupdated for non-trivial changes