Fix Jaeger remote sampler declarative config polling interval key - #8649
Fix Jaeger remote sampler declarative config polling interval key#8649thswlsqls wants to merge 2 commits into
Conversation
Pull request dashboard statusClosed · refreshed 2026-08-11 14:30 UTC Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8649 +/- ##
=========================================
Coverage 91.64% 91.64%
- Complexity 10348 10349 +1
=========================================
Files 1013 1013
Lines 27380 27382 +2
Branches 3218 3218
=========================================
+ Hits 25092 25095 +3
Misses 1558 1558
+ Partials 730 729 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…y-java into fix/jaeger-remote-sampler-declarative-interval-key
jack-berg
left a comment
There was a problem hiding this comment.
This was already fixed in #8668. The diff was rendering wrongly indicating that JaegerRemoteSamplerComponentProvider still was reading "internal" despite it being updated on main to read "interval": https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/internal/JaegerRemoteSamplerComponentProvider.java#L50
I pushed a merge commit with main and the diff went away. Closing this because its just test coverage at this point and we fixed the coverage gap in #8668 using a different strategy.
Fixes #8648
Description
JaegerRemoteSamplerComponentProvider.create()readconfig.getLong("internal"), a key that does not exist, sogetLongalways returned null and the configured polling interval was silently dropped.ExperimentalJaegerRemoteSamplerModeldefines the field as@JsonProperty("interval"), matching the sibling keysendpointandinitial_samplerthat were already correct."interval"so a user-configured value is honored; when omitted the builder default (60000ms) still applies.Testing done
SamplerFactoryTest#create_JaegerRemote_interval(configured 10000ms honored) and#create_JaegerRemote_intervalDefault(omitted → 60000ms default), driving the real declarative pipeline.pollingIntervalMsfield andgetPollingIntervalMs()visible-for-testing accessor onJaegerRemoteSamplerso the interval can be observed; no public API change (apidiff unchanged).expected: 10000 but was: 60000) and passes after the fix../gradlew :sdk-extensions:jaeger-remote-sampler:check— passed../gradlew :sdk-extensions:declarative-config:check— passed (SamplerFactoryTest: 19 tests).