Remove Prometheus host default migration log - #8720
Closed
viminizer wants to merge 2 commits into
Closed
Conversation
The log was added in open-telemetry#8298 to warn users that PrometheusHttpServer's default host changed from 0.0.0.0 to localhost, with a TODO to remove it after the 1.64.0 release. Both 1.64.0 and 1.65.0 have since shipped, so the warning has served its purpose. Removing it also removes the only reason `host` was nullable, so it now defaults to DEFAULT_HOST directly and the null handling in build() goes away.
Pull request dashboard statusClosed · refreshed 2026-08-12 02:03 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8720 +/- ##
=========================================
Coverage 91.64% 91.64%
+ Complexity 10351 10350 -1
=========================================
Files 1003 1003
Lines 27211 27206 -5
Branches 3199 3198 -1
=========================================
- Hits 24937 24933 -4
Misses 1566 1566
+ Partials 708 707 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Closing — this duplicates #8679, which @jack-berg opened on 31 July and which I missed before opening this. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the migration log in
PrometheusHttpServerBuilder, per the TODO left in #8298:// TODO (jack-berg): Remove log after 1.64.0 release1.64.0 shipped on 2026-07-10 and 1.65.0 on 2026-08-07, so the condition has been met for two releases.
Scope note: I also made
hostnon-nullable. The field comment said it was "Temporarily nullable to detect when it's not set and log warning about 0.0.0.0 -> localhost change" — the log was the only reason for the nullability, sohostnow initialises toDEFAULT_HOSTand theresolvedHostnull check inbuild()is gone. Happy to cut this back to removing only the log if you'd prefer the smaller diff.I left the
setHostJavadoc note about the previous0.0.0.0default in place, since that's still useful to users and outside what the TODO covered../gradlew :exporters:prometheus:checkpasses. No public API change, so no apidiff updates.