fix: use the store passed to Collection.save and drop the dead resolver option - #115
Open
ehennestad wants to merge 1 commit into
Open
fix: use the store passed to Collection.save and drop the dead resolver option#115ehennestad wants to merge 1 commit into
ehennestad wants to merge 1 commit into
Conversation
Contributor
ehennestad
force-pushed
the
fix-collection-store-options
branch
from
August 31, 2026 09:49
e2d1ff0 to
3b4e7f8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## support-cross-namespace-loading #115 +/- ##
===================================================================
+ Coverage 79.80% 79.84% +0.04%
===================================================================
Files 423 423
Lines 4070 4069 -1
===================================================================
+ Hits 3248 3249 +1
+ Misses 822 820 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ehennestad
force-pushed
the
fix-collection-store-options
branch
from
August 31, 2026 10:20
b427088 to
3b4e7f8
Compare
ehennestad
force-pushed
the
fix-collection-store-options
branch
from
August 31, 2026 10:39
0806e62 to
d68984b
Compare
Contributor
ehennestad
force-pushed
the
fix-collection-store-options
branch
from
September 1, 2026 14:31
d68984b to
4019af2
Compare
…er option Passing a metadata store to save by name-value failed on any collection that was not constructed with one. The branch checked options.MetadataStore but called save on obj.MetadataStore, which defaults to an empty store, so the call errored on the empty object instead of using the store it was given. Found while verifying that an external database integration can work purely through the MetadataStore interface. The constructor also accepted a LinkResolver option that was never stored and a LinkResolver property that nothing read. Resolvers are registered through openminds.registerLinkResolver and selected per reference from the registry, so a collection-level resolver has no role. Both are removed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ehennestad
force-pushed
the
fix-collection-store-options
branch
from
September 1, 2026 20:58
4019af2 to
7b511a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying that an external graph database can integrate purely through the extension interfaces: a mock database with its own serializer, deserializer, metadata store and resolver, written against
BaseSerializer,BaseDeserializer,openminds.interface.MetadataStoreandAbstractLinkResolverwithout touching this repository.Passing a store to save by name-value failed
obj.MetadataStoredefaults to an empty store, so on any collection not constructed with a store the call errored withInvalid object. Value must be a scalar.rather than using the store it was given. The documented usagecollection.save("", "MetadataStore", store)therefore never worked. It now calls the store fromoptions.Regression test added: saving through a name-value store on a collection constructed without one.
The dead LinkResolver option is removed
The constructor accepted
options.LinkResolverbut never assigned it, and theLinkResolverproperty was never read by anything. Resolvers are registered throughopenminds.registerLinkResolverand selected per reference from the registry, so a collection-level resolver has no role in the design that landed in this stack. Keeping a silently ignored parameter is worse than not having it, and nothing uses it — openminds-kg-sync included.🤖 Generated with Claude Code