fix: remove duplicate accumulate_delta in assistants streaming - #3578
Open
bunlongheng wants to merge 1 commit into
Open
fix: remove duplicate accumulate_delta in assistants streaming#3578bunlongheng wants to merge 1 commit into
bunlongheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/streaming/_assistants.pycontained a private copy ofaccumulate_delta(lines 983-1041) that was byte-for-byte identical to the canonical version inlib/streaming/_deltas.py:6-64.The chat streaming path already imports from
_deltas(seelib/streaming/chat/_completions.py:25), but assistants streaming maintained its own duplicate - meaning any bugfix to one copy would silently miss the other.Change
_assistants.pyaccumulate_deltafrom._deltas(same as chat streaming already does)is_dict/is_listimports from_utilsVerification
No behavior change - both call sites (lines 910, 961) continue calling the same function, now through the shared import.