docs(wasm): hand the diff to edit as generateDiff returns it - #783
Merged
Conversation
`odr.generateDiff()` returns the json already stringified, so the README's `JSON.stringify` around it handed `edit` a json string where it parses an object: `json["modifiedText"]` then throws `[json.exception.type_error.305] cannot use operator[] with a string argument with string`. Checked against 6.12.0 both ways. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P4A5LwMDmeD3sxJ3MaTr5Q
andiwand
added a commit
that referenced
this pull request
Aug 30, 2026
`odr.generateDiff()` returns the json already stringified, so the README's `JSON.stringify` around it handed `edit` a json string where it parses an object: `json["modifiedText"]` then throws `[json.exception.type_error.305] cannot use operator[] with a string argument with string`. Checked against 6.12.0 both ways. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
odr.generateDiff()ends inreturn JSON.stringify(result), so the README'sJSON.stringifyaround it handsedita json string wherehtml::editparses an object.
json["modifiedText"]then throws:Checked against 6.12.0 from npm, both ways, on a document rendered with
editable: true:Found while wiring the round trip into the opendocument.app viewer, which is
where the snippet gets copied from.
No
CHANGELOG.mdentry: the binding is unchanged, only what the README claimsabout calling it.