Skip to content

test(data): advance the reference-output pins onto the run #824 pushed - #830

Closed
andiwand wants to merge 1 commit into
mainfrom
test/advance-reference-output-pins
Closed

test(data): advance the reference-output pins onto the run #824 pushed#830
andiwand wants to merge 1 commit into
mainfrom
test/advance-reference-output-pins

Conversation

@andiwand

@andiwand andiwand commented Sep 6, 2026

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

main is red, and so is every open pull request: the test leg's
compare-html step dies before it compares anything.

ValueError: 'build/test/output/odr-public/output/ods/file_example_ODS_100.ods-read-only'
  is not in the subpath of 'test/data/reference-output/odr-public/output'

#824 regenerated and pushed reference output but left test/data.cmake pinned
at #819's revisions, so CI clones a tree two commits behind what the suite now
writes. The first directory with no reference is
ods/file_example_ODS_100.ods-read-only, one of the second-config outputs #699
added — and htmlcmp reports it by building the failure's path with
relative_to(a) for a path that lives under b, so it raises instead. The
crash is what you see; the pin lag is what caused it.

Two lines, onto the commits that match main today:

from to
reference-output/odr-public 8d9a545 (#819) a89a503 (#824)
reference-output/odr-private a83bd65 (#819) 27f6637 (#824)

Not the tips of those repositories — the commit above each is in-flight work
that has not landed here.

Verified

A full RelWithDebInfo run of the suite, diffed against both output repositories
checked out at exactly these two commits:

diff -rq  public:  0 lines
diff -rq  private: 0 lines

#824 pushed regenerated reference output but left `test/data.cmake` pinned at
#819's revisions, so CI clones a tree that predates the outputs the suite now
writes. `compare-html` then dies on a directory it has no reference for —
`ods/file_example_ODS_100.ods-read-only`, added by #699 — rather than reporting
it, because it builds the failure's path with `relative_to(a)` for a path under
`b`. Every open pull request fails the `test` leg on it, main included.

Verified: a full RelWithDebInfo run diffs byte-identical (`diff -rq`, 0 lines)
against both output repositories at these two commits.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0195navGk6vKJcZ6cjrWsNDP
@andiwand

andiwand commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Superseded by #829, which advanced both pins to the repository tips (29fc194 / d7aa0dc) — covering #824's regeneration as well as its own pdf class rename. main is green again, so this two-line bump has nothing left to do.

@andiwand andiwand closed this Sep 6, 2026
@andiwand
andiwand deleted the test/advance-reference-output-pins branch September 6, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant