test(data): advance the reference-output pins onto the run #824 pushed - #830
Closed
andiwand wants to merge 1 commit into
Closed
test(data): advance the reference-output pins onto the run #824 pushed#830andiwand wants to merge 1 commit into
andiwand wants to merge 1 commit into
Conversation
#824 pushed regenerated reference output but left `test/data.cmake` pinned at #819's revisions, so CI clones a tree that predates the outputs the suite now writes. `compare-html` then dies on a directory it has no reference for — `ods/file_example_ODS_100.ods-read-only`, added by #699 — rather than reporting it, because it builds the failure's path with `relative_to(a)` for a path under `b`. Every open pull request fails the `test` leg on it, main included. Verified: a full RelWithDebInfo run diffs byte-identical (`diff -rq`, 0 lines) against both output repositories at these two commits. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195navGk6vKJcZ6cjrWsNDP
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
mainis red, and so is every open pull request: thetestleg'scompare-htmlstep dies before it compares anything.#824 regenerated and pushed reference output but left
test/data.cmakepinnedat #819's revisions, so CI clones a tree two commits behind what the suite now
writes. The first directory with no reference is
ods/file_example_ODS_100.ods-read-only, one of the second-config outputs #699added — and htmlcmp reports it by building the failure's path with
relative_to(a)for a path that lives underb, so it raises instead. Thecrash is what you see; the pin lag is what caused it.
Two lines, onto the commits that match
maintoday:reference-output/odr-public8d9a545(#819)a89a503(#824)reference-output/odr-privatea83bd65(#819)27f6637(#824)Not the tips of those repositories — the commit above each is in-flight work
that has not landed here.
Verified
A full RelWithDebInfo run of the suite, diffed against both output repositories
checked out at exactly these two commits: