fix(android): name the locale the xref offsets are formatted in - #854
Merged
Conversation
`lintDebug` fails the aar build on `DefaultLocale`: the fixture's `String.format` for an xref entry takes whatever locale the device has, and a pdf's offsets are ascii digits in every one of them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018e3PEzyU2oAFSzsEoWsSmz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
The
aarjob has failed on main since #850:The fixture formats a pdf xref entry, whose offsets are ascii digits in every
locale, so
Locale.ROOTis both what lint wants and what the format means —the same call
Color.toStringalready makes.Nothing else in
jni/java,jni/testfixturesorandroid/srcuses alocale-sensitive format.