Keep asking for a banner after one does not fill - #188
Merged
Conversation
andiwand
force-pushed
the
keep-asking-after-a-banner-does-not-fill
branch
from
September 1, 2026 19:26
0c177f9 to
a63577e
Compare
didFailToReceiveAdWithError hid the banner and nothing asked again for the life of the controller. The ad unit only refreshes a banner that is on screen, and a hidden one is not, so a single refusal left the slot silent until the next document. It is the same hole droid#643 closes on Android; this is the iOS half. A failure now schedules its own ask, rescheduling before each request so one that never answers cannot end the chain, and a refresh that does not fill keeps the ad already on screen instead of hiding a live one. A suspended app cannot fire the work item, so backgrounding needs no guard.
andiwand
force-pushed
the
keep-asking-after-a-banner-does-not-fill
branch
from
September 1, 2026 19:27
a63577e to
2cc4050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
didFailToReceiveAdWithErrorhid the banner and calledonNoAd, and nothing asked again for the life of the controller. The ad unit's automatic refresh only runs for a banner that is on screen — a hidden one is not — so a single refusal left the slot silent until the next document.It is the same hole droid#643 closes on Android; this is the iOS half.
What changes
CrashManagerbreadcrumb, as the consent flow already does.Notes
DispatchWorkItemcannot fire while the app is suspended, so unlike the Android side this needs no pause/resume plumbing.load()'swidth != requestedWidthguard is deliberately bypassed by the retry, which callsbannerView.loaddirectly — a retry wants the same width it just failed at.load(), and indeinit.reportNoAd()runs with no retry at all. That deserves its own change.🤖 Generated with Claude Code