Skip to content

Stop the phone drawing its own links over a document #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andiwand merged 2 commits into from
Sep 6, 2026
Merged

Stop the phone drawing its own links over a document #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95b8c29
Stop the phone drawing its own links over a document
andiwand Sep 6, 2026
7f7a040
Say it in three lines
andiwand Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ open: **a second build under the same version goes under the already cut
heading, not back under `Unreleased`.** Date the heading and add its compare link
once the version tag exists.

## [Unreleased]

### Fixed

- An email address or a date in a PDF no longer has a link drawn over it,
which showed the text twice.

## [1.44]

### Changed
Expand Down Expand Up @@ -283,7 +290,7 @@ submitted.
- An incorrect password is now reported as such instead of a generic failure.
- Page handling and decryption fixes when opening protected documents.

[Unreleased]: https://github.com/opendocument-app/OpenDocument.ios/compare/v1.43...HEAD
[Unreleased]: https://github.com/opendocument-app/OpenDocument.ios/compare/v1.44...HEAD
[1.43]: https://github.com/opendocument-app/OpenDocument.ios/compare/v1.42...v1.43
[1.42]: https://github.com/opendocument-app/OpenDocument.ios/compare/v1.41...v1.42
[1.41]: https://github.com/opendocument-app/OpenDocument.ios/compare/v1.40...v1.41
Expand Down
15 changes: 15 additions & 0 deletions OpenDocumentReader/DocumentWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import WebKit

/// Built here rather than decoded: a nib turns every data detector on, and a
/// configuration cannot be changed once the view has it. Detectors draw links
/// over the invisible text a pdf carries for selection and search.
final class DocumentWebView: WKWebView {

required init?(coder: NSCoder) {
let configuration = WKWebViewConfiguration()
configuration.dataDetectorTypes = []
configuration.mediaTypesRequiringUserActionForPlayback = []

super.init(frame: .zero, configuration: configuration)
}
}
2 changes: 1 addition & 1 deletion OpenDocumentReader/Main.storyboard
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
</progressView>
</subviews>
</stackView>
<wkWebView contentMode="scaleToFill" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="VF5-Do-xh9">
<wkWebView contentMode="scaleToFill" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="VF5-Do-xh9" customClass="DocumentWebView" customModule="OpenDocumentReader" customModuleProvider="target">
<rect key="frame" x="0.0" y="190" width="414" height="706"/>
<autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
<color key="backgroundColor" red="0.36078431370000003" green="0.38823529410000002" blue="0.4039215686" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
Expand Down