Take the renderer's 6.13.0, and keep the call its readme now gets wrong - #1
Merged
Conversation
The engine's javascript surface did not move: `index.js`, `odr-core.mjs` and `index.d.ts` are byte-identical to 6.12.0, and `fileTypes()` and the enum tables come back the same, so there is no binding here to start calling. What grew is the wasm, and what it renders - paged content restates its zoom as a `text-size-adjust` percentage, so a phone stops scaling the type a second time over the box it was fitted to, and a table cell starts at its top the way word and odf say it should rather than at the browser's centre. Both arrive by opening a document; nothing on this side opts in. The one thing that did change in the package is its readme, and it changed to something untrue: it now says `generateDiff()` returns json already and that `edit` wants that object, not a string. The binding underneath is a `std::string`, in 6.13.0 as in 6.12.0 - an object throws `BindingError` at both - so following it would break saving an edited document. `saveDocument` keeps stringifying, and says why, because the next reader of that readme will come back here. Checked against the built site rather than the tarball: the sample document opens on the served 6.13.0, and a diff in the shape this page sends applies and survives into the saved file it reopens. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019JsBLdSBxzmHFQ4CFDiknj
|
Visit the preview URL for this PR (updated for commit f67ad31): https://admob-app-id-9025061963--pr1-bump-odr-core-6-13-0-bwfvxkza.web.app (expires Fri, 18 Sep 2026 06:47:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0d3d5ed9702d729bc1b3ec04fb565e826dd7179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@opendocument/odr-core6.12.0 → 6.13.0.Nothing new to call
The JavaScript surface did not move. Against the two tarballs,
index.js,odr-core.mjsandindex.d.tsare byte-identical, and loading both and comparingenumsandfileTypes()gives no difference — no new formats, no newHtmlConfigoption, no new binding. So there is no feature here to adopt; the version bump is the adoption.What we get anyway
The wasm grew ~184 KB, and the change is in what it renders. Diffing the html for
public/sample.odtbetween the two:text-size-adjustunder a css zoom, and where it does, restates the zoom as a percentage so a paged document's text holds the box it was fitted to. Also applied under@media print.td{vertical-align:top}— Word and ODF put a cell's content at its top where the browser default centres it.Both arrive just by opening a document. Nothing on this side opts in.
The readme regression
The only other change in the package is its README, and it changed to something untrue:
That is backwards.
editbinds to astd::string, so the object is what throws — checked by driving both versions directly:edit(JSON.stringify(diff))edit(diff)BindingError: Cannot pass non-string to std::stringBindingError: Cannot pass non-string to std::stringindex.d.tsagrees with the behaviour, not the readme:edit(diff: string).saveDocumentalready passes a string and is correct, so the code does not change — but it now carries a comment saying why, because someone reading that readme will otherwise come here and "fix" it, and that breaks saving an edited document. Worth reporting upstream.Verified
npm run buildandastro checkclean (0 errors/warnings/hints).scripts/sync-odr.mjsemitspublic/odr/6.13.0/and the forwarder points at it; the version reaches the bundle via__ODR_VERSION__.sample.odtopens and renders, and a diff in the exact shapeviewer.tssends applies, saves, and the edit is still there when the saved bytes are reopened. No console errors."license": "MPL-2.0"line npm dropped from the lock entry — registry metadata for a package published hours ago, the license is unchanged in both.🤖 Generated with Claude Code
https://claude.ai/code/session_019JsBLdSBxzmHFQ4CFDiknj