MSYS2: fix package manager -> OpenCV 4 - #8531
Merged
Merged
Conversation
MSYS2 recently moved to OpenCV 5, whose pkg-config module is opencv5 instead of opencv4. install_dependencies.sh only checked for opencv4 before falling back to opencv (v3), so on opencv5-only environments the build failed with "Package 'opencv' not found". Detection now tries opencv5, then opencv4, then opencv (v3), and the sed rewrite of ofxOpenCv/addon_config.mk uses a single pattern that matches any of the three module names as the prior state, so it works regardless of what was previously written to the file.
danoli3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix msys2 package manager to OpenCV 4 instead of 5