Fix force merge async response deserialization - #2148
Open
xujiantop-crypto wants to merge 1 commit into
Open
Conversation
xujiantop-crypto
requested review from
Bukhtawar,
VachaShah,
Xtansia,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
September 9, 2026 11:04
Signed-off-by: Xu Jian <265865031+xujiantop-crypto@users.noreply.github.com>
xujiantop-crypto
force-pushed
the
fix/forcemerge-async-response
branch
from
September 9, 2026 11:05
fbb2497 to
59cb40d
Compare
reta
requested changes
Sep 9, 2026
| application/json: | ||
| schema: | ||
| allOf: | ||
| oneOf: |
Collaborator
There was a problem hiding this comment.
@xujiantop-crypto please send the change request against https://github.com/opensearch-project/opensearch-api-specification/ repo [1], thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix force merge response deserialization when
wait_for_completion=false. The OpenAPI response now models the synchronous_shardspayload and asynchronoustaskpayload as alternatives, so generatedForcemergeResponse.shards()is nullable while synchronous responses continue to deserialize normally.Adds regression coverage for both response shapes using the JSON-B and Jackson mappers.
Issues Resolved
Closes #2147.
Testing
:java-client:unitTest(616 tests, 0 failures):java-codegen:test(66 tests, 0 failures):java-client:spotlessJavaCheck:java-codegen:spotlessJavaCheckBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.