Skip to content

Add Applier/Operator components and combining rule - #209

Open
rafabene wants to merge 1 commit into
openshift-hyperfleet:mainfrom
rafabene:add-applier-component
Open

Add Applier/Operator components and combining rule#209
rafabene wants to merge 1 commit into
openshift-hyperfleet:mainfrom
rafabene:add-applier-component

Conversation

@rafabene

@rafabene rafabene commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Applier (hyperfleet-applier) and Operator (hyperfleet-operator) to the valid components table — both repos had no matching component, so their work was mislabeled under Infra/Adapter/Architecture
  • Splits the table into domain components (which system) and cross-cutting components (which kind of work), and documents when to combine one of each (e.g. Applier + Architecture for a domain-specific design spike, Operator + Documentation for a CR reference guide)
  • Created during ticket hygiene review of HYPERFLEET-1517–1521, which surfaced that hyperfleet-applier and hyperfleet-operator work had been absorbed into Infra/Adapter/Architecture for lack of a dedicated component

Test plan

  • Tables render correctly and stay alphabetically ordered within each group

@openshift-ci
openshift-ci Bot requested review from aredenba-rh and tirthct August 20, 2026 12:42
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 574f6043-5e84-4614-a007-2f03deba1ad0

📥 Commits

Reviewing files that changed from the base of the PR and between b9cd85e and ca17f4d.

📒 Files selected for processing (1)
  • hyperfleet/standards/ticket-hygiene.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Reorganized valid ticket components into domain and cross-cutting categories.
    • Added Applier and Operator domain components.
    • Removed Operator scope from Infra.
    • Added guidance for combining components across domains and work types.

Walkthrough

The ticket hygiene standard separates domain and cross-cutting components. It adds Applier and Operator as domain components. It limits Infra to Helm and deployment responsibilities. It adds rules for combining components across domains and work types.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ca17f

This is a localized documentation change with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: tirthct, aredenba-rh

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed The PR changes only ticket-hygiene.md. The added lines contain no slog, log, logr, zap, fmt.Print*, token, password, credential, or secret log fields.
No Hardcoded Secrets ✅ Passed Only documentation changed; added lines contain no hardcoded credentials, embedded-credential URLs, secret assignments, or base64 strings over 32 characters.
No Weak Cryptography ✅ Passed Only hyperfleet/standards/ticket-hygiene.md changed. The added content is documentation and introduces no banned primitive, custom cryptography, or secret comparison.
No Injection Vectors ✅ Passed The PR changes only ticket-hygiene.md. The diff adds no SQL construction, exec.Command, template.HTML, or yaml.Unmarshal patterns under CWE-89, CWE-78, CWE-79, or CWE-502.
No Privileged Containers ✅ Passed PR #209 changes only ticket-hygiene.md; the diff adds no Kubernetes, Helm, or Dockerfile privilege settings, so no CWE-250 condition is introduced.
No Pii Or Sensitive Data In Logs ✅ Passed The commit changes only ticket-hygiene.md; the diff adds component documentation and contains no logging statements or sensitive-data logging patterns.
Title check ✅ Passed The title clearly identifies the added Applier and Operator components and the new combining rule.
Description check ✅ Passed The description directly explains the component-table changes, combining rules, affected repositories, and ticket-hygiene purpose.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

Adds Applier (hyperfleet-applier) and Operator (hyperfleet-operator)
to the valid components list — both repos previously had no matching
component and their work was mislabeled under Infra/Adapter/Architecture.

Splits the Valid Components table into domain (which system) and
cross-cutting (which kind of work) groups, and documents when to
combine one of each (e.g. Applier + Architecture for a domain-specific
design spike, Operator + Documentation for a CR reference guide).
@rafabene
rafabene force-pushed the add-applier-component branch from b9cd85e to ca17f4d Compare August 20, 2026 12:55
@rafabene rafabene changed the title Add Applier component to valid components list Add Applier/Operator components and combining rule Aug 20, 2026
@kuudori

kuudori commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kuudori
Once this PR has been reviewed and has the lgtm label, please assign rafabene for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pnguyen44

Copy link
Copy Markdown
Contributor

Last Updated is still 2026-05-20. Worth bumping since this adds new components and a new subsection.

@pnguyen44

pnguyen44 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

PR titles need a JIRA prefix per the commit standard. Add a ticket reference if one exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants