Skip to content

: [release-4.22] OCPBUGS-115316: GCP: Set Universe Domain - #264

Open
patrickdillon wants to merge 4 commits into
openshift:release-4.22from
patrickdillon:gcd-422
Open

: [release-4.22] OCPBUGS-115316: GCP: Set Universe Domain#264
patrickdillon wants to merge 4 commits into
openshift:release-4.22from
patrickdillon:gcd-422

Conversation

@patrickdillon

@patrickdillon patrickdillon commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sets the universe doamin in GCP, which is necessary for any GCP environment not using the default universe domain. Particularly we are targeting Google Dedicated Cloud (GDC), the sovereign cloud offering.

Manual cherry-pick of #249

@patrickdillon
GCP: Set Universe Domain
cff6e4b 
Sets the universe doamin in GCP, which is necessary for any
GCP environment not using the default universe domain. Particularly
we are targeting Google Dedicated Cloud (GDC), the sovereign cloud
offering.
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci
openshift-ci Bot requested review from jcaamano and miheer September 1, 2026 17:52
@patrickdillon

patrickdillon commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/jira cherrypick OCPBUGS-115169

@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2026

Copy link
Copy Markdown

@patrickdillon: Jira Issue OCPBUGS-115169 has been cloned as Jira Issue OCPBUGS-115316. Will retitle bug to link to clone.
/retitle OCPBUGS-115316: GCP: Set Universe Domain

Details

In response to this:

/jira cherrypick OCPBUGS-115169

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title GCP: Set Universe Domain OCPBUGS-115316: GCP: Set Universe Domain Sep 1, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2026

Copy link
Copy Markdown

@patrickdillon: This pull request references Jira Issue OCPBUGS-115316, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Sets the universe doamin in GCP, which is necessary for any GCP environment not using the default universe domain. Particularly we are targeting Google Dedicated Cloud (GDC), the sovereign cloud offering.

Manual cherry-pick of #249

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
GCP: update to non-deprecated auth functions
4ef6c15 
Updates from WithCredentialsJSON -> WithAuthCredentialsJSON
and FromCredentialsJSON -> FromCredentialsJSONWithType to avoid
using the deprecated function. This change is a no-op, only
intended to avoid deprecation.

The new functions takes a credential type parameter, which can be
used to limit accepted credentials types, which is useful for
validating credentials provided by external third parties.

For OpenShift, cluster credentials are coming from first party users
running clusters in their project, so we do not need to limit which
credentials are accepted; therefore we just pass the type through
from the credential to the function.
@patrickdillon
go.mod: include latest google api packages
692be47 
Bump google.golang.org/api to v0.288.0 which includes the
non-deprecated WithAuthCredentialsJSON and CredentialsType
authentication libraries.
@patrickdillon
vendor: updated google api packages
92f2326 
go mod tidy && go mod vendor
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fa4201da-d150-4db4-91eb-d156e88dfd28

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@patrickdillon patrickdillon mentioned this pull request Sep 1, 2026
Merged
tthvo
tthvo reviewed Sep 1, 2026
View reviewed changes

@tthvo tthvo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn
/test e2e-azure-ovn
/test e2e-azure-serial-1of2
/test e2e-azure-serial-2of2
/test e2e-gcp-ovn
/test hypershift-e2e-aks

@tthvo

tthvo commented Sep 1, 2026

Copy link
Copy Markdown
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 1, 2026

Copy link
Copy Markdown

@tthvo: This pull request references Jira Issue OCPBUGS-115316, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-115169 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-115169 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 92f2326 link true /test e2e-azure-ovn
ci/prow/security 92f2326 link false /test security
ci/prow/e2e-aws-ovn 92f2326 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz

kyrtapz commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

/retitle: [release-4.22] OCPBUGS-115316: GCP: Set Universe Domain
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci Bot changed the title OCPBUGS-115316: GCP: Set Universe Domain : [release-4.22] OCPBUGS-115316: GCP: Set Universe Domain Sep 2, 2026
@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 2, 2026
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, patrickdillon, tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2026
@patrickdillon patrickdillon mentioned this pull request Sep 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcaamano jcaamano Awaiting requested review from jcaamano
@miheer miheer Awaiting requested review from miheer
1 more reviewer
@tthvo tthvo tthvo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@tthvo tthvo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patrickdillon @openshift-ci-robot @tthvo @kyrtapz