OCPBUGS-115900: CNF-26697: [release-5.0] CORENET-7330: Allow per-node OVN encap IP override via env-overrides - #3124
Conversation
Teach the ovnkube node startup wrapper to source OVN_ENCAP_IP from the per-node env-overrides ConfigMap and pass it to ovnkube as --encap-ip. Normalize whitespace in the override so single-IP and comma-separated encap IP values are passed safely as one shell argument, and keep coverage for the optional env-overrides mount used for day2 updates. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORENET-7330 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/cherry-pick release-4.22 |
|
@cgoncalves: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test images |
|
/pipeline required |
|
Scheduling required tests: Scheduling tests matching the |
|
CNO secondary encap CI lanes being added in openshift/release#83663 |
|
/retest-required |
|
/retitle CNF-26697: [release-5.0] CORENET-7330: Allow per-node OVN encap IP override via env-overrides |
|
@openshift-cherrypick-robot: This pull request references CNF-26697 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@cgoncalves: This pull request references CNF-26697 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test |
|
/test e2e-metal-ipi-ovn-secondary-encap |
1 similar comment
|
/test e2e-metal-ipi-ovn-secondary-encap |
|
I kicked it off again, afaict it failed on something unrelated (https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/3124/pull-ci-openshift-cluster-network-operator-release-5.0-e2e-metal-ipi-ovn-secondary-encap/2092925553907601408) |
|
/test e2e-metal-ipi-ovn-secondary-encap |
|
Hi @cgoncalves @andreaskaris Thanks for covering on this one. @tssurya can you please review and add the lgtm/approve labels? /retest-required |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/label backport-risk-assessed |
|
@SchSeba: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@SchSeba: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
Hi @tssurya, this two lanes continue to failed but they are not related to this change at all. can you override I feeling we are just wasting CI resources on this.. |
|
/jira cherrypick OCPBUGS-115895 |
|
@SchSeba: Jira Issue OCPBUGS-115895 has been cloned as Jira Issue OCPBUGS-115900. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-115900, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jire refresh |
|
/retest-required |
|
/jira refresh |
|
@SchSeba: This pull request references Jira Issue OCPBUGS-115900, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@SchSeba: This pull request references Jira Issue OCPBUGS-115900, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@SchSeba: This pull request references Jira Issue OCPBUGS-115900, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed |
This is an automated cherry-pick of #2998
/assign cgoncalves