OCPBUGS-92663: CVE-2026-46597 openshift4/ose-console: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.12.z] - #16983
Conversation
…ypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.12.z]
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pipeline required |
|
Scheduling required tests: |
… 3.3.0 The CI i18n check was failing because locale files were generated with i18next-parser 6.5.0 (locally installed) instead of 3.3.0 (lockfile-pinned). Version 3.3.0 uses _plural suffix convention while 6.5.0 uses _one/_other, causing format mismatches detected by the CI git status check.
|
/pipeline required |
|
Scheduling required tests: |
|
On the 4.12 branch (OCPBUGS-92663), the changes were limited to the SSH dependency bump, regenerated i18n locale files, and two whitespace-only gofmt comment fixes in unrelated backend files. The failure here was in e2e/knative-ci.feature, which failed entirely in a before-all hook: it timed out after 150 seconds waiting for the Red Hat OpenShift Serverless operator to report a fully healthy install status, causing all 14 dependent tests to be skipped. This points to operator installation or catalog timing in the test environment rather than anything in the console code. |
|
From former assessment: /override ci/prow/e2e-gcp-console |
|
@germanparente: Overrode contexts on behalf of germanparente: ci/prow/e2e-gcp-console DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/jira refresh |
|
@tonyxrmdavidson: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92663, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: germanparente, tonyxrmdavidson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/verified by CI |
|
@germanparente: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tonyxrmdavidson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/jira refresh |
|
@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92663, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
OCPBUGS-92663: CVE-2026-46597 — golang.org/x/crypto/ssh Denial of Service [openshift-4.12.z]
Vulnerability
CVE-2026-46597 is a Denial of Service vulnerability in
golang.org/x/crypto/sshcaused by crafted AES-GCM packet decoder inputs. An attacker could exploit malformed SSH packets to crash or hang the server.Remediation steps
Replaced
golang.org/x/cryptowith a patched fork: Added areplacedirective ingo.modto pingolang.org/x/cryptotogithub.com/openshift-sustaining/crypto v0.24.0-sec.3, which contains the fix for CVE-2026-46597.Bumped transitive
golang.org/x/dependencies to compatible versions required by the patched crypto module:golang.org/x/crypto: v0.5.0 -> v0.23.0 (replaced by patched fork)golang.org/x/net: v0.5.0 -> v0.25.0golang.org/x/sys: v0.4.0 -> v0.21.0golang.org/x/mod: v0.6.0 -> v0.17.0golang.org/x/sync: v0.1.0 -> v0.7.0golang.org/x/term: v0.4.0 -> v0.21.0golang.org/x/text: v0.6.0 -> v0.16.0Regenerated vendor directory: Ran
go mod tidy && go mod vendorto sync all vendored dependencies with the updatedgo.mod.Fixed test infrastructure to unblock CI after the dependency update:
test-backend.sh: Scoped thegit statusvendor consistency check tovendor/,go.mod, andgo.sumonly. The previousgit status --porcelain --ignoredwas picking up unrelated ignored directories (e.g.node_modules/,.claude/), causing false positives.build-i18n.sh: Resolved thei18nextbinary path absolutely using the script's directory. Yarn 4 does not injectnode_modules/.bininto PATH for child shell processes, so the barei18nextcommand was not found.Regenerated i18n locale files: Ran
yarn i18nto update 13 out-of-date locale files. These were pre-existing drift unrelated to the CVE fix.Fixed gofmt formatting: Ran
gofmtonpkg/server/resource_lister.goandpkg/version/version.goto fix pre-existing comment formatting issues.Test results