Skip to content

OCPBUGS-92663: CVE-2026-46597 openshift4/ose-console: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.12.z] - #16983

Open
tonyxrmdavidson wants to merge 3 commits into
openshift:release-4.12from
tonyxrmdavidson:OCPBUGS-92663-CVE-2026-46597-4-12
Open

tonyxrmdavidson wants to merge 3 commits into
openshift:release-4.12from
tonyxrmdavidson:OCPBUGS-92663-CVE-2026-46597-4-12

Conversation

@tonyxrmdavidson

Copy link
Copy Markdown

OCPBUGS-92663: CVE-2026-46597 — golang.org/x/crypto/ssh Denial of Service [openshift-4.12.z]

Vulnerability

CVE-2026-46597 is a Denial of Service vulnerability in golang.org/x/crypto/ssh caused by crafted AES-GCM packet decoder inputs. An attacker could exploit malformed SSH packets to crash or hang the server.

Remediation steps

  1. Replaced golang.org/x/crypto with a patched fork: Added a replace directive in go.mod to pin golang.org/x/crypto to github.com/openshift-sustaining/crypto v0.24.0-sec.3, which contains the fix for CVE-2026-46597.

  2. Bumped transitive golang.org/x/ dependencies to compatible versions required by the patched crypto module:

    • golang.org/x/crypto: v0.5.0 -> v0.23.0 (replaced by patched fork)
    • golang.org/x/net: v0.5.0 -> v0.25.0
    • golang.org/x/sys: v0.4.0 -> v0.21.0
    • golang.org/x/mod: v0.6.0 -> v0.17.0
    • golang.org/x/sync: v0.1.0 -> v0.7.0
    • golang.org/x/term: v0.4.0 -> v0.21.0
    • golang.org/x/text: v0.6.0 -> v0.16.0
  3. Regenerated vendor directory: Ran go mod tidy && go mod vendor to sync all vendored dependencies with the updated go.mod.

  4. Fixed test infrastructure to unblock CI after the dependency update:

    • test-backend.sh: Scoped the git status vendor consistency check to vendor/, go.mod, and go.sum only. The previous git status --porcelain --ignored was picking up unrelated ignored directories (e.g. node_modules/, .claude/), causing false positives.
    • build-i18n.sh: Resolved the i18next binary path absolutely using the script's directory. Yarn 4 does not inject node_modules/.bin into PATH for child shell processes, so the bare i18next command was not found.
  5. Regenerated i18n locale files: Ran yarn i18n to update 13 out-of-date locale files. These were pre-existing drift unrelated to the CVE fix.

  6. Fixed gofmt formatting: Ran gofmt on pkg/server/resource_lister.go and pkg/version/version.go to fix pre-existing comment formatting issues.

Test results

  • Backend: vendor consistency check, Go tests, gofmt, govet all pass
  • Frontend: i18n check passes; eslint and unit tests have pre-existing failures unrelated to this change (prettier/no-shadow errors across the codebase on this branch)

…ypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.12.z]
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 08f75892-0ce8-4c70-9499-128f716b9dff

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cloudbehl and florkbr August 13, 2026 15:45
@openshift-ci openshift-ci Bot added component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/insights Related to insights plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Aug 13, 2026
@tonyxrmdavidson

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-gcp-console

… 3.3.0

  The CI i18n check was failing because locale files were generated with
  i18next-parser 6.5.0 (locally installed) instead of 3.3.0 (lockfile-pinned).
  Version 3.3.0 uses _plural suffix convention while 6.5.0 uses _one/_other,
  causing format mismatches detected by the CI git status check.
@tonyxrmdavidson

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-gcp-console

@tonyxrmdavidson

Copy link
Copy Markdown
Author

On the 4.12 branch (OCPBUGS-92663), the changes were limited to the SSH dependency bump, regenerated i18n locale files, and two whitespace-only gofmt comment fixes in unrelated backend files. The failure here was in e2e/knative-ci.feature, which failed entirely in a before-all hook: it timed out after 150 seconds waiting for the Red Hat OpenShift Serverless operator to report a fully healthy install status, causing all 14 dependent tests to be skipped. This points to operator installation or catalog timing in the test environment rather than anything in the console code.

@germanparente

Copy link
Copy Markdown
Contributor

From former assessment:

/override ci/prow/e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@germanparente: Overrode contexts on behalf of germanparente: ci/prow/e2e-gcp-console

Details

In response to this:

From former assessment:

/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tonyxrmdavidson tonyxrmdavidson changed the title Ocpbugs 92663 CVE 2026 46597 4 12 OCPBUGS-92663: CVE-2026-46597 openshift4/ose-console: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.12.z] Aug 31, 2026
@openshift-ci-robot openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Aug 31, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 31, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92663, which is invalid:

  • expected Jira Issue OCPBUGS-92663 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-92663: CVE-2026-46597 — golang.org/x/crypto/ssh Denial of Service [openshift-4.12.z]

Vulnerability

CVE-2026-46597 is a Denial of Service vulnerability in golang.org/x/crypto/ssh caused by crafted AES-GCM packet decoder inputs. An attacker could exploit malformed SSH packets to crash or hang the server.

Remediation steps

  1. Replaced golang.org/x/crypto with a patched fork: Added a replace directive in go.mod to pin golang.org/x/crypto to github.com/openshift-sustaining/crypto v0.24.0-sec.3, which contains the fix for CVE-2026-46597.

  2. Bumped transitive golang.org/x/ dependencies to compatible versions required by the patched crypto module:

  • golang.org/x/crypto: v0.5.0 -> v0.23.0 (replaced by patched fork)
  • golang.org/x/net: v0.5.0 -> v0.25.0
  • golang.org/x/sys: v0.4.0 -> v0.21.0
  • golang.org/x/mod: v0.6.0 -> v0.17.0
  • golang.org/x/sync: v0.1.0 -> v0.7.0
  • golang.org/x/term: v0.4.0 -> v0.21.0
  • golang.org/x/text: v0.6.0 -> v0.16.0
  1. Regenerated vendor directory: Ran go mod tidy && go mod vendor to sync all vendored dependencies with the updated go.mod.

  2. Fixed test infrastructure to unblock CI after the dependency update:

  • test-backend.sh: Scoped the git status vendor consistency check to vendor/, go.mod, and go.sum only. The previous git status --porcelain --ignored was picking up unrelated ignored directories (e.g. node_modules/, .claude/), causing false positives.
  • build-i18n.sh: Resolved the i18next binary path absolutely using the script's directory. Yarn 4 does not inject node_modules/.bin into PATH for child shell processes, so the bare i18next command was not found.
  1. Regenerated i18n locale files: Ran yarn i18n to update 13 out-of-date locale files. These were pre-existing drift unrelated to the CVE fix.

  2. Fixed gofmt formatting: Ran gofmt on pkg/server/resource_lister.go and pkg/version/version.go to fix pre-existing comment formatting issues.

Test results

  • Backend: vendor consistency check, Go tests, gofmt, govet all pass
  • Frontend: i18n check passes; eslint and unit tests have pre-existing failures unrelated to this change (prettier/no-shadow errors across the codebase on this branch)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed
/label approved
/lgtm

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 1, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-gcp-console

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2026
@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: germanparente, tonyxrmdavidson
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@germanparente

Copy link
Copy Markdown
Contributor

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 1, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92663, which is invalid:

  • expected dependent Jira Issue OCPBUGS-92691 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/backend Related to backend component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/insights Related to insights plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants