Skip to content

Fix goreleaser parallel builds (use CLI flag, not config field) - #956

Merged
dustman9000 merged 1 commit into
openshift:masterfrom
dustman9000:fix-goreleaser-parallelism-2
Aug 28, 2026
Merged

Fix goreleaser parallel builds (use CLI flag, not config field)#956
dustman9000 merged 1 commit into
openshift:masterfrom
dustman9000:fix-goreleaser-parallelism-2

Conversation

@dustman9000

@dustman9000 dustman9000 commented Aug 28, 2026

Copy link
Copy Markdown
Member

Follow-up to #955. The parallelism field doesn't exist in goreleaser's build config schema -- it needs to be passed as a CLI flag instead. This caused the release to fail immediately with a YAML unmarshal error.

Changes:

  • Reverts the invalid parallelism: 2 from .goreleaser.yml
  • Passes --parallelism 2 via the goreleaser action args in both release.yaml and release-on-version-bump.yaml

Summary by CodeRabbit

  • Chores
    • Limited release build parallelism to improve build stability.
    • Applied the same release configuration consistently across automated release workflows.

GitHub-hosted runners are being killed mid-build when all 4
cross-compilation targets run concurrently. Pass --parallelism 2 to
goreleaser to reduce peak resource usage without making the build fully
sequential. Also reverts the invalid parallelism field from .goreleaser.yml.
@dustman9000
dustman9000 merged commit bae9a4d into openshift:master Aug 28, 2026
5 of 11 checks passed
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 00e686c6-5a2b-4480-98c6-f7671c7940ad

📥 Commits

Reviewing files that changed from the base of the PR and between bf52a07 and f50af72.

📒 Files selected for processing (3)
  • .github/workflows/release-on-version-bump.yaml
  • .github/workflows/release.yaml
  • .goreleaser.yml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting


Walkthrough

The release workflows now pass --parallelism 2 to GoReleaser. The shared GoReleaser configuration no longer defines the build parallelism limit.

Changes

Release parallelism

Layer / File(s) Summary
Workflow-controlled GoReleaser parallelism
.goreleaser.yml, .github/workflows/release-on-version-bump.yaml, .github/workflows/release.yaml
The shared configuration removes parallelism: 2. Both release workflows pass --parallelism 2 to GoReleaser while retaining clean releases.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2026
@dustman9000 dustman9000 added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:51 PM UTC · Completed 12:59 PM UTC

Commit: f50af72 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.98

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend pre-review check

@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open PRs/MRs.

Posted by fullsend post-review check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant