Skip to content

ci-staging: allow Prucek/ci-staging to own the aws cluster profile - #83657

Closed
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:ci-staging-aws-profile-owner
Closed

ci-staging: allow Prucek/ci-staging to own the aws cluster profile#83657
Prucek wants to merge 1 commit into
openshift:mainfrom
Prucek:ci-staging-aws-profile-owner

Conversation

@Prucek

@Prucek Prucek commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • keep cluster-profile ownership checks in config-check
  • add Prucek/ci-staging as an owner of the aws profile so in-repo config-check can pass for tests that use cluster_profile: aws

Prucek/release was already listed; GNU_go_sort does not use a cluster profile.

Test plan

  • Confirm ci-staging .ci-operator.yaml uses cluster_profile: aws
  • After merge, open/sync a PR on Prucek/ci-staging that touches .ci-operator.yaml and confirm ci-operator-config-check passes the ownership check

Made with Cursor

Summary by CodeRabbit

  • Adds Prucek/ci-staging as an owner of the aws cluster profile.
  • Allows ci-staging tests that use cluster_profile: aws to pass config-check ownership validation.

Config-check fails for in-repo configs that use cluster_profile: aws because ownership is gated by cluster-profiles-config.yaml. Keep that check and add the staging test repo next to the existing Prucek/release owner.

Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci
openshift-ci Bot requested review from sosiouxme and xueqzhan August 19, 2026 12:02
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c287d5f3-8eb5-43a1-998c-ea5eda576e5b

📥 Commits

Reviewing files that changed from the base of the PR and between 87ba535 and 9191f83.

📒 Files selected for processing (1)
  • ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The AWS cluster profile configuration now assigns the ci-staging repository to Prucek.

Changes

AWS profile ownership

Layer / File(s) Summary
Update AWS ownership configuration
ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml
The Prucek entry for the aws cluster now includes the ci-staging repository.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9191f

This localized configuration change adds the staging repository as an owner of the AWS cluster profile; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: josecastillolema, patrickdillon

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the change that allows Prucek/ci-staging to own the aws cluster profile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only YAML by adding Prucek/ci-staging to the aws owners; it introduces no Ginkgo test title or dynamic test value.
Test Structure And Quality ✅ Passed The pull request changes only one YAML owner entry and introduces no Ginkgo test code, so the listed test-structure requirements are not applicable.
Microshift Test Compatibility ✅ Passed The patch changes only cluster-profiles-config.yaml by adding ci-staging as an AWS profile owner; it adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only one cluster-profile ownership YAML line and adds no Ginkgo tests or multi-node assumptions subject to this check.
Topology-Aware Scheduling Compatibility ✅ Passed The diff adds one repository owner entry to a YAML cluster-profile config; it does not add or modify manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The parent diff contains one YAML-only change to cluster-profile ownership and no executable source changes, so it introduces no OTE process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only cluster-profiles-config.yaml by adding an owner repository; it adds no Ginkgo e2e test and introduces no IPv4 or external-connectivity behavior.
No-Weak-Crypto ✅ Passed The PR diff adds only the ci-staging owner entry to a YAML cluster-profile list; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The diff adds only ci-staging to an ownership list; it introduces no privileged container, host namespace, SYS_ADMIN, privilege escalation, or root setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only the YAML entry - ci-staging under a cluster-profile owner; it introduces no logging code or sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Prucek: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 19, 2026
@openshift-ci

openshift-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@Prucek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prucek Prucek closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant