Fix an obvious issue with the LMS Date Sync form in the Sets Manager. - #3121
Merged
Merged
Conversation
The date synchronization form id is `lms_date_sync`, not `lms_roster_sync`. This clearly makes the LMS Date Synchronization be always shown regardless of the conditions for which it is not supposed be shown.
Alex-Jordan
approved these changes
Aug 7, 2026
somiaj
approved these changes
Aug 7, 2026
somiaj
added a commit
that referenced
this pull request
Aug 7, 2026
Fix an obvious issue with the LMS Date Sync form in the Sets Manager. (hotfix of #3121)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The date synchronization form id is
lms_date_sync, notlms_roster_sync. This clearly makes the LMS Date Synchronization be always shown regardless of the conditions for which it is not supposed be shown.