Conversation
The phys share a device tree node, so mt76_eeprom_override() will always load the exact same address for both. Fix by moving the local address modification outside the eeprom fallback block, making it conditional on actual address conflicts. This will also catch any buggy eeprom with the same valid address in both fields. Signed-off-by: Bjørn Mork <bjorn@mork.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phys share a device tree node, so mt76_eeprom_override() will always load the exact same address for both.
Fix by moving the local address modification outside the eeprom fallback block, making it conditional on actual address conflicts. This will also catch any buggy eeprom with the same valid address in both fields.