Document per repo upload key - #116
Merged
Merged
Conversation
rgaudin removed the org-level KIWIX_FILE_UPLOAD_SSH_KEY: since the April 2026 infra change the download server uses per-repository usernames and keys, so an org-wide secret for a single repo served no purpose. The repo-level JAVASCRIPTLIBZIM_FILE_UPLOAD_KEY is the intended answer, not a stopgap. The workflow comments still told a future maintainer to switch back to the org secret once it was re-stored, which would now point at a secret that no longer exists. The script header named it too. No functional change: both workflows already read the repo-level secret. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
v0.95 shipped with the org-level secret migration and its CHANGELOG entry says so, which is accurate for that tag but confusing now the migration has been undone. An Unreleased section records the reversion so the two entries can be read together, rather than rewriting the history of a published release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes now-incorrect documentation in code, and adds CHANGELOG entries.