Skip to content

Fix submit button loading state race #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 2 commits into from
Aug 21, 2026
Merged

Fix submit button loading state race #3344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ade851
fix submit button loading state race
david-crespo Aug 21, 2026
277710b
a bit of cleanup: add comments, move transition setup to CSS
david-crespo Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions app/ui/lib/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* Copyright Oxide Computer Company
*/
import cn from 'classnames'
import * as m from 'motion/react-m'
import { type MouseEventHandler, type ReactNode } from 'react'

import { type BadgeColor } from '@oxide/design-system/ui'
Expand Down Expand Up @@ -120,25 +119,19 @@ export const Button = ({
{...rest}
>
{loading && (
<m.span
animate={{ opacity: 1, y: '-50%', x: '-50%' }}
initial={{ opacity: 0, y: 'calc(-50% - 25px)', x: '-50%' }}
transition={{ type: 'spring', duration: 0.3, bounce: 0 }}
className="absolute top-1/2 left-1/2 flex items-center justify-center"
>
<span className="button-spinner-in absolute top-1/2 left-1/2 flex -translate-x-1/2 -translate-y-1/2 items-center justify-center">
<Spinner variant={variantToBadgeColorMap[variant || 'primary']} />
</m.span>
</span>
)}
<m.span
className={cn('flex items-center', innerClassName)}
animate={{
opacity: loading ? 0 : 1,
y: loading ? 25 : 0,
}}
transition={{ type: 'spring', duration: 0.3, bounce: 0 }}
<span
className={cn(
'button-content flex items-center',
loading ? 'translate-y-[25px] opacity-0' : 'translate-y-0 opacity-100',
innerClassName
)}
>
{children}
</m.span>
</span>
</button>
</Wrap>
)
Expand Down
33 changes: 33 additions & 0 deletions app/ui/styles/components/button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@

.ox-button {
@apply relative;
/*
* Shared by the spinner keyframes and the .button-content transition below.
* Approximates Motion's { type: 'spring', duration: 0.3, bounce: 0 }.
*/
--button-loading-easing: cubic-bezier(0.35, 0.98, 0.35, 1);

&:after {
content: '';
Expand Down Expand Up @@ -72,3 +77,31 @@
.active-clicked:active:not(.visually-disabled) {
@apply motion-safe:translate-y-px;
}

/* Animating transform is deliberate: the spinner's centering utilities set the
* separate translate property, which composes with transform instead of being
* overridden by it. */
@keyframes button-spinner-in {
from {
opacity: 0;
transform: translateY(-25px);
}
to {
opacity: 1;
transform: translateY(0);
}
}

@media (prefers-reduced-motion: no-preference) {
.ox-button .button-spinner-in {
animation: button-spinner-in 0.3s var(--button-loading-easing);
}

/* Button label; swaps out as the spinner drops in. Loading state is toggled
* with utility classes in Button.tsx. */
.ox-button .button-content {
transition:
opacity 0.3s var(--button-loading-easing),
translate 0.3s var(--button-loading-easing);
}
}
Loading