Fix error handling in disk attach modal - #3346
Open
david-crespo wants to merge 1 commit into
Open
Conversation
…then-attach chain gets error toast
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs found while doing #3345:
Silent attach failure in the create-then-attach flow. In the unlikely event you create a disk from the storage tab and the subsequent attach call fails (e.g., the instance started in the meantime), there was no visible error: the error only rendered inside the attach modal, which isn't open anymore. You'd get the "Disk created" toast but the disk just wouldn't be attached. Now it shows an error toast.
Stale error leaking between modal uses. In that failure scenario, the error stuck to the shared mutation, so the next time you opened the "Attach existing disk" modal, it displayed the old error from the create flow before you'd done anything. Now the attach modal's mutation is its own, created fresh on each open.
Moving the mutation inside its own component means we don't have to do
reset()s to avoid holding onto state across different openings of the attach modal.