[server] restore SMBIOS type 1 input on instance ensure - #1200
Open
zeeshanlakhani wants to merge 1 commit into
Open
[server] restore SMBIOS type 1 input on instance ensure#1200zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
The instance spec versioning rework in #1178 moved the API-to-internal conversion into per-version `SpecBuilder` paths, but dropped the assignment of the API spec's `smbios` field to the internal spec's `smbios_type1_input`. As a result, ensure requests with an explicit SMBIOS Type 1 input silently receive Propolis's default Type 1 values (`Oxide`/`OxVM`) instead. This breaks consumers of programmable SMBIOS (#977), like voxel and a4x2, where the SMBIOS manufacturer selects a4x2 hardware and the product and serial values identify the sled's configured `BaseboardId` during bootstrap. This change preserves `smbios` in `latest_to_spec_builder`, the common funnel for the versioned instance-spec conversion paths, and adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instance spec versioning rework in #1178 moved the API-to-internal conversion into per-version
SpecBuilderpaths, but dropped the assignment of the API spec'ssmbiosfield to the internal spec'ssmbios_type1_input.As a result, ensure requests with an explicit SMBIOS Type 1 input silently receive Propolis's default Type 1 values (
Oxide/OxVM) instead. This breaks consumers of programmable SMBIOS (#977), like voxel and a4x2, where the SMBIOS manufacturer selects a4x2 hardware and the product and serial values identify the sled's configuredBaseboardIdduring bootstrap.This change preserves
smbiosinlatest_to_spec_builder, the common funnel for the versioned instance-spec conversion paths, and adds a regression test.