Skip to content

fix SeSecurityPrivilege error - #1747

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix-windows-ingest-script
Aug 9, 2026
Merged

fix SeSecurityPrivilege error#1747
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix-windows-ingest-script

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Simplified temporary configuration handling during collector setup.
    • Configuration replacement is now performed more reliably after validation.
    • Removed unnecessary backup-file and cleanup steps.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7e43f380-54e0-4bb5-b6f7-97473732ab2c

📥 Commits

Reviewing files that changed from the base of the PR and between 48ae5a3 and bcdc3ae.

📒 Files selected for processing (1)
  • scripts/ingest.ps1

Walkthrough

Setup-Collector now uses a GUID-based temporary configuration path. After validation, it moves the temporary configuration directly into place. Backup creation, ACL reset, and backup cleanup were removed.

Changes

Collector configuration update

Layer / File(s) Summary
Temporary configuration replacement
scripts/ingest.ps1
Setup-Collector generates the temporary path inline. After validation, it uses Move-Item for direct replacement and retains temporary-file cleanup in finally.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: pratik50

Poem

A rabbit checks the config trail,
A GUID marks the temp-file rail.
Validation hops, then files move,
No backup burrow left to prove.
Cleanup waits in finally too.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required description, rationale, key changes, issue reference, and test checklist are missing. Add a description with the goal, chosen solution and rationale, key changes, issue reference if applicable, and completed testing and documentation checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the SeSecurityPrivilege error addressed by the Windows ingestion script change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit b6600ee into parseablehq:main Aug 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants