chore(demos): update various react demos - #12586
Open
andrew-ronaldson wants to merge 5 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughReact Table demos now use PatternFly ChangesTable label status migration
Notification badge variants
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-table/src/demos/examples/TableCompact.tsx`:
- Around line 117-123: Normalize the Needs Maintenance switch case to the
sample-data key Needs maintenance so the label renders correctly. Apply this
change in the status renderers at
packages/react-table/src/demos/examples/TableCompact.tsx#L117-L123,
TableSortableResponsive.tsx#L124-L130, TableStaticBottomPagination.tsx#L71-L89,
and TableStickyHeader.tsx#L10-L16; leave the associated label statuses
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cdcbf011-5583-47eb-96c9-2adcf12b81bf
📒 Files selected for processing (8)
packages/react-table/src/demos/examples/TableColumnManagement.tsxpackages/react-table/src/demos/examples/TableColumnManagementWithDraggable.tsxpackages/react-table/src/demos/examples/TableCompact.tsxpackages/react-table/src/demos/examples/TableExpandCollapseAll.tsxpackages/react-table/src/demos/examples/TableFilterable.tsxpackages/react-table/src/demos/examples/TableSortableResponsive.tsxpackages/react-table/src/demos/examples/TableStaticBottomPagination.tsxpackages/react-table/src/demos/examples/TableStickyHeader.tsx
andrew-ronaldson
changed the title
rebeccaalpert
self-requested a review
August 3, 2026 15:57
rebeccaalpert
approved these changes
Aug 3, 2026
rebeccaalpert
left a comment
rebeccaalpert
left a comment
Member
There was a problem hiding this comment.
Some demos still seem to need the updated alert icon:
- patternfly-react/packages/react-core/src/demos/examples/Page/PageContextSelector.tsx
- patternfly-react/packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
- patternfly-react/packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
- patternfly-react/packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
- patternfly-react/packages/react-table/src/demos/DashboardHeader.tsx
I don't mind pushing these.
CodeRabbit also has a good callout worth fixing here. I can push to your PR to get that closed up.
Needs Maintenance was being used rather than the lowercase version in the actual data. This meant some labels were missing after render step.
Left the component-specific examples alone, but replaced remaining nav usage.
kmcfaul
approved these changes
Aug 3, 2026
thatblindgeye
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12528 AND patternfly/patternfly-design#1683
Summary by CodeRabbit
Bug Fixes
Style