FIX: 404 status for result not found - #139
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Heimdall’s HTTP error-to-status mapping so the API returns 404 Not Found when a requested job result is not yet available (via ErrResultNotReady), aligning that condition with existing “file not found on S3” behavior.
Changes:
- Added an
ErrResultNotReadycase instatusForErrorto returnhttp.StatusNotFound(404).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nitin Bhakar (nitinbhakar)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an update to the error handling logic in the
statusForErrorfunction. Specifically, it adds a case to return a 404 Not Found status when theErrResultNotReadyerror is encountered to match existing behaviour of 404 status if file is not yet available on s3.Error handling improvements:
statusForErrorfunction ininternal/pkg/heimdall/handler.goto returnhttp.StatusNotFound(404) when the error matchesErrResultNotReady.